From owner-svn-src-all@FreeBSD.ORG  Sat May 21 22:31:27 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 51E821065672;
	Sat, 21 May 2011 22:31:27 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 2DBFF8FC16;
	Sat, 21 May 2011 22:31:27 +0000 (UTC)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id C1FE946B06;
	Sat, 21 May 2011 18:31:26 -0400 (EDT)
Date: Sat, 21 May 2011 23:31:26 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Luigi Rizzo <luigi@FreeBSD.org>
In-Reply-To: <alpine.BSF.2.00.1105212327440.35370@fledge.watson.org>
Message-ID: <alpine.BSF.2.00.1105212330270.35370@fledge.watson.org>
References: <201011121302.oACD2Qjt009385@svn.freebsd.org>
	<alpine.BSF.2.00.1105212327440.35370@fledge.watson.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r215178 - in head: lib/libc/sys sys/kern sys/sys
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 May 2011 22:31:27 -0000


On Sat, 21 May 2011, Robert Watson wrote:

> In fact, the code I pointed at in my previous e-mail will probably panic in 
> that case, since it improperly dereferences the inpcb's socket field without 
> first testing for NULL.

Or, looking more closely, only because the locking is broken, as it does test 
inp_socket.  However, it really shouldn't need to -- we try quite hard never 
to dereference inp_socket in the firewall code for this reason.  Hence, among 
other things, propagating so_cred down as inp_cred.

Robert