From owner-freebsd-arch@FreeBSD.ORG Wed Apr 9 19:59:23 2008 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9294C106566C for ; Wed, 9 Apr 2008 19:59:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 15E6B8FC0A for ; Wed, 9 Apr 2008 19:59:22 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8s) with ESMTP id 238513915-1834499 for multiple; Wed, 09 Apr 2008 15:58:16 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m39JxAuE070969; Wed, 9 Apr 2008 15:59:11 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Kostik Belousov Date: Wed, 9 Apr 2008 15:50:27 -0400 User-Agent: KMail/1.9.7 References: <321309.94192.qm@web37604.mail.mud.yahoo.com> <200804091125.46505.jhb@freebsd.org> <20080409192918.GM21209@deviant.kiev.zoral.com.ua> In-Reply-To: <20080409192918.GM21209@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804091550.27806.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 09 Apr 2008 15:59:11 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/6689/Wed Apr 9 12:20:19 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Rick Hunnicutt , freebsd-arch@freebsd.org Subject: Re: fdclone KPI X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Apr 2008 19:59:23 -0000 On Wednesday 09 April 2008 03:29:18 pm Kostik Belousov wrote: > On Wed, Apr 09, 2008 at 11:25:46AM -0400, John Baldwin wrote: > > On Wednesday 09 April 2008 12:01:44 am Kostik Belousov wrote: > > > On Tue, Apr 08, 2008 at 04:09:30PM -0700, Rick Hunnicutt wrote: > > > > I'm curious if someone can tell me why the fdclone KPI was not included in > > the 7.0 release? > > > > > > Because it got no > > > - review; > > > - interest from the driver authors; > > > - agreement that this is the way to go. > > > > Oof, where is the patch? I think it is definitely easier for people to use > > than devfs cloning when all that is needed is per-instance data. I would use > > it in the ipmi(4) driver and the nvidia graphics driver would likely prefer > > it to devfs cloning as well. > > http://people.freebsd.org/~kib/misc/fdclone.10.patch > http://people.freebsd.org/~kib/misc/fclone.c > > The patch was developed before the struct file becomes lockless. The link > above contains the mechanically updated patch, that was given one > smoke-test run. > > fclone.c is the trivial driver that utilizes the new KPI. Oh, so this still does devfs style cloning just under the covers. Hmm, I thought you had actually added a new 'void *f_foo' member to struct file. -- John Baldwin