From owner-svn-src-all@freebsd.org Wed Mar 13 18:19:37 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 61A89153C723; Wed, 13 Mar 2019 18:19:37 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C1C258DB8F; Wed, 13 Mar 2019 18:19:35 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x2DIJQ5H021149; Wed, 13 Mar 2019 11:19:26 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x2DIJQBY021148; Wed, 13 Mar 2019 11:19:26 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201903131819.x2DIJQBY021148@gndrsh.dnsmgr.net> Subject: Re: svn commit: r345088 - head/libexec/rc In-Reply-To: <201903131700.x2DH0GGY022977@repo.freebsd.org> To: "Bjoern A. Zeeb" Date: Wed, 13 Mar 2019 11:19:25 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: C1C258DB8F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.96)[-0.957,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 18:19:37 -0000 > Author: bz > Date: Wed Mar 13 17:00:15 2019 > New Revision: 345088 > URL: https://svnweb.freebsd.org/changeset/base/345088 > > Log: > Enhance IPv6 autoconf startup. > > Before this change we would only run rtsol on an interface which was > set to accept_rtadv and did not have rtsold enabled. This change > removes the latter condition and always runs rtsol (rather than the > deferred rtsold) to reduce the delay until we send the first RS. > > This change will also handle the accept_rtadv before dhcp hence > starting IPv6 auto-configuration before IPV4 DHCP. > > This change is intended for FreeBSD 13 and later only and will not be MFCed. May I ask why it has decided that this is not to be merged to stable/12? It looks to me that this fix is very applicable, and should not cause an issue, one simply gets out an RS packet earlier, and your v6 gets set sooner, allowing other configuration stuff that depends on v6 being up working rather than failing. Is there some prior work that is not mergable? Is there some danger of causing a problem? Thanks, Rod > Reviewed by: hrs > Differential Revision: https://reviews.freebsd.org/D19488 > > Modified: > head/libexec/rc/network.subr > > Modified: head/libexec/rc/network.subr > ============================================================================== > --- head/libexec/rc/network.subr Wed Mar 13 15:18:14 2019 (r345087) > +++ head/libexec/rc/network.subr Wed Mar 13 17:00:15 2019 (r345088) > @@ -229,6 +229,11 @@ ifconfig_up() > ${IFCONFIG_CMD} $1 up > fi > > + if ! noafif $1 && afexists inet6; then > + ipv6_accept_rtadv_up $1 > + _cfg=0 > + fi > + > if dhcpif $1; then > if [ $_cfg -ne 0 ] ; then > ${IFCONFIG_CMD} $1 up > @@ -686,7 +691,6 @@ ipv6_up() > > ifalias ${_if} inet6 alias && _ret=0 > ipv6_prefix_hostid_addr_common ${_if} alias && _ret=0 > - ipv6_accept_rtadv_up ${_if} && _ret=0 > > return $_ret > } > @@ -1198,8 +1202,8 @@ ipv6_accept_rtadv_up() > { > if ipv6_autoconfif $1; then > ${IFCONFIG_CMD} $1 inet6 accept_rtadv up > - if ! checkyesno rtsold_enable; then > - rtsol ${rtsol_flags} $1 > + if [ -x /sbin/rtsol ]; then > + /sbin/rtsol ${rtsol_flags} $1 > fi > fi > } > > -- Rod Grimes rgrimes@freebsd.org