From owner-cvs-all@FreeBSD.ORG  Sat Sep 11 09:55:52 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BAEDE106566C;
	Sat, 11 Sep 2010 09:55:52 +0000 (UTC)
	(envelope-from remko@elvandar.org)
Received: from mailgate.jr-hosting.nl (mailgate.jr-hosting.nl
	[IPv6:2a01:4f8:63:1281::3])
	by mx1.freebsd.org (Postfix) with ESMTP id 7A0D98FC0C;
	Sat, 11 Sep 2010 09:55:52 +0000 (UTC)
Received: from websrv01.jr-hosting.nl (mailrelay.jr-hosting.nl
	[IPv6:2a01:4f8:63:1281::4])
	by mailgate.jr-hosting.nl (Postfix) with ESMTP id D9FED1CC32;
	Sat, 11 Sep 2010 11:55:51 +0200 (CEST)
Received: from [2001:980:4a50:0:21e:c2ff:febc:d902]
	by websrv01.jr-hosting.nl with esmtpsa (TLSv1:AES128-SHA:128)
	(Exim 4.72 (FreeBSD)) (envelope-from <remko@elvandar.org>)
	id 1OuMoJ-00059P-N0; Sat, 11 Sep 2010 11:55:51 +0200
Mime-Version: 1.0 (Apple Message framework v1081)
Content-Type: text/plain; charset=us-ascii
From: Remko Lodder <remko@elvandar.org>
In-Reply-To: <20100911095133.GA98291@FreeBSD.org>
Date: Sat, 11 Sep 2010 11:55:50 +0200
Content-Transfer-Encoding: 7bit
Message-Id: <74745E4D-B9A7-4ABC-A13C-6D6B4ECC1130@elvandar.org>
References: <201009110907.o8B97h9o041593@repoman.freebsd.org>
	<2FE6FEAD-AEC7-47B3-BF09-7058908F3D42@elvandar.org>
	<20100911095133.GA98291@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
X-Mailer: Apple Mail (2.1081)
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/sysutils/nvclock/files patch-src::Makefile.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Sep 2010 09:55:52 -0000


On Sep 11, 2010, at 11:51 AM, Alexey Dokuchaev wrote:

> On Sat, Sep 11, 2010 at 11:33:20AM +0200, Remko Lodder wrote:
>> On Sep 11, 2010, at 11:07 AM, Alexey Dokuchaev wrote:
>>> 
>>> Closes PR:      ports/149434
>> 
>> We refer to this as
>> 
>> PR:	<category>/<number>
> 
> In most cases, yes, absolutely, but:
> 
> The committed patch was not from the PR; submitter suggested marking the
> port as jobs-unsafe (and I hate marking ports unsafe or broken instead of
> properly fixing them).  Technically, I could have omitted any attribution
> whatsoever, but decided to do it nonetheless (making clear that commit
> merely closes the PR, not taking any code/idea from it).  Thanks for
> asking though.
> 
> ./danfe

no, when refering to a PR we always do that.

We can tell in the changelog itself that the PR had not been used itself.


-- 
/"\   Best regards,                        | remko@FreeBSD.org
\ /   Remko Lodder                      | remko@EFnet
X    http://www.evilcoder.org/    |
/ \   ASCII Ribbon Campaign    | Against HTML Mail and News