From owner-cvs-all@FreeBSD.ORG Tue May 4 16:26:43 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44B8016A4CE; Tue, 4 May 2004 16:26:43 -0700 (PDT) Received: from alcanet.com.au (mail2.alcanet.com.au [203.62.196.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5908743D49; Tue, 4 May 2004 16:26:39 -0700 (PDT) (envelope-from peter.jeremy@alcatel.com.au) Received: from sydsmtp02.alcatel.com.au (IDENT:root@localhost.localdomain [127.0.0.1])i44NQYiL006104; Wed, 5 May 2004 09:26:34 +1000 Received: from gsmx07.alcatel.com.au ([139.188.20.247]) by sydsmtp02.alcatel.com.au (Lotus Domino Release 5.0.12) with ESMTP id 2004050509263344:62547 ; Wed, 5 May 2004 09:26:33 +1000 Received: from gsmx07.alcatel.com.au (localhost [127.0.0.1]) i44NQXHQ069692; Wed, 5 May 2004 09:26:33 +1000 (EST) (envelope-from peter.jeremy@alcatel.com.au) Received: (from jeremyp@localhost) by gsmx07.alcatel.com.au (8.12.9p2/8.12.9/Submit) id i44NQWnZ069691; Wed, 5 May 2004 09:26:32 +1000 (EST) (envelope-from peter.jeremy@alcatel.com.au) Date: Wed, 5 May 2004 09:26:32 +1000 From: Peter Jeremy To: Tim Kientzle Message-ID: <20040504232632.GA69416@gsmx07.alcatel.com.au> Mail-Followup-To: Tim Kientzle , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Andrew.Li@alcatel.com.au References: <200405041721.i44HL22l029797@repoman.freebsd.org> Mime-Version: 1.0 In-Reply-To: <200405041721.i44HL22l029797@repoman.freebsd.org> User-Agent: Mutt/1.4.2i X-MIMETrack: Itemize by SMTP Server on SYDSMTP02/AlcatelAustralia(Release 5.0.12 |February 13, 2003) at 05/05/2004 09:26:33 AM,|February 13, 2003) at 05/05/2004 09:26:34 AM, Serialize complete at 05/05/2004 09:26:34 AM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Andrew.Li@alcatel.com.au Subject: Re: cvs commit: src/usr.bin/tar fts.c fts.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2004 23:26:43 -0000 On 2004-May-04 10:21:02 -0700, Tim Kientzle wrote: >kientzle 2004/05/04 10:21:02 PDT > > FreeBSD src repository > > Added files: > usr.bin/tar fts.c fts.h > Log: > Include local copies of fts.c and fts.h to be used ONLY on non-FreeBSD > systems. The fts.h here is an exact copy of include/fts.h (except for > an initial explanatory comment and the revision tags, of course). The > fts.c here is slightly modified from lib/libc/gen/fts.c so it can > compile correctly on non-FreeBSD systems. Since a colleague of mine has just finished porting fts(3) to Tru64, I was interested in the changes you needed to make. Having looked, it seems that your changes are primarily aimed at Linux compatibility rather than general portability - it's unlikely that your fts.c will be usable on anything other than Linux systems due to the '#ifdef LINUX' near the top - if this was '#ifndef __FreeBSD__', the portability would be enhanced. Also, why wasn't this done as a repocopy? This would have made it far easier to see the changes. -- Peter Jeremy