Date: Wed, 16 Jan 2013 18:26:21 +0800 From: Marcelo Araujo <araujobsdport@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r310483 - in head/devel/tpasm: . files Message-ID: <CAOfEmZjiagmFMrejrvo_zn5xfZY%2BtN5XoDC34oY88_SJ8QwZzA@mail.gmail.com> In-Reply-To: <20130116100330.GA12459@FreeBSD.org> References: <201301160817.r0G8Hrws045649@svn.freebsd.org> <20130116100330.GA12459@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2013/1/16 Alexey Dokuchaev <danfe@freebsd.org> > On Wed, Jan 16, 2013 at 08:17:53AM +0000, Marcelo Araujo wrote: > > New Revision: 310483 > > URL: http://svnweb.freebsd.org/changeset/ports/310483 > > > > Log: > > - Update to 1.8. > > - Trim header. > > I must say I see a lot of gratuitous changes that 1) do not seem to improve > anything (yet recude readability); and 2) are not mentioned in the log. > Well it depends! For me, this way has more readability. OK, does not improve nothing, but unfortunately there is no documentation saying we should follow this standard or not. In this case here, in my point of view, we can use BIKESHED. > > > PR: ports/174183 > > Submitted by: KATO Tsuguru <tkato432@yahoo.com> > > Something unexpected from KATO-san. :( > I hope Kato can be more motivated and contribute much more. > > > do-install: > > - ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin > > + (cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin) > > @${MKDIR} ${PREFIX}/libdata/${PORTNAME} > > - ${INSTALL_DATA} ${WRKSRC}/include/* ${PREFIX}/libdata/${PORTNAME} > > + (cd ${WRKSRC}/include \ > > + && ${INSTALL_DATA} * ${PREFIX}/libdata/${PORTNAME}) > > .if !defined(NOPORTDOCS) > > @${MKDIR} ${DOCSDIR} > > - ${INSTALL_DATA} ${WRKSRC}/CONVERSION_C166.TXT ${WRKSRC}/MANUAL.TXT > \ > > - ${WRKSRC}/README*.TXT ${DOCSDIR} > > +.for i in CONVERSION_C166.TXT MANUAL.TXT README*.TXT > > + (cd ${WRKSRC} && ${INSTALL_DATA} ${i} ${DOCSDIR}) > > +.endfor > > .endif > > .if !defined(NOPORTEXAMPLES) > > @${MKDIR} ${EXAMPLESDIR} > > - ${INSTALL_DATA} ${WRKSRC}/samples/* ${EXAMPLESDIR} > > + (cd ${WRKSRC}/samples && ${INSTALL_DATA} * ${EXAMPLESDIR}) > > .endif > > I am referring to this particualr part of the patch. I will probably fix > it > later if I happen to touch this port again. > Go ahead, feel free to change and improve! Best Regards, -- Marcelo Araujo araujo@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOfEmZjiagmFMrejrvo_zn5xfZY%2BtN5XoDC34oY88_SJ8QwZzA>