Date: Wed, 8 Aug 2018 11:27:41 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: ports@freebsd.org Subject: Re: Stage-qa doesn't complain about unstripped elfs in many cases Message-ID: <20180808092741.3mwliq4lippwbwrz@ogg.in.absolight.net> In-Reply-To: <d39dba89-3d22-fbeb-3e40-5cdfe6c39310@rawbw.com> References: <d39dba89-3d22-fbeb-3e40-5cdfe6c39310@rawbw.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--ffgbtnlwq2dnztg4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 07, 2018 at 11:29:39PM -0700, Yuri wrote: > For example, on the misc/orange3 port: >=20 > > $ make stage-qa > > =3D=3D=3D=3D> Running Q/A tests (stage-qa) > > [yuri@yv /usr/ports/misc/orange3]$ file ./work-py36/stage/usr/local/lib= /python3.6/site-packages/Orange/widgets/utils/_grid_density.so > > ./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/= utils/_grid_density.so: > ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically > linked, not stripped >=20 >=20 > This is because the stage-qa check only looks at .debug sections, and > file(1) looks at more sections. >=20 > My proposed partial fix was rejected: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230371 on the grounds= that > it goes against some other commit. So stage-qa doesn't check what it is > supposed to check, and this is somehow ok. >=20 >=20 > Should this stage-qa check be changed to just run file(1) and check if the > output contains "not stripped" in it? What would be the downside of this?= I > also don't understand what is the downside of the rejected patch in > bug#230371 that expands the list of sections. I do not understand the point of this email. I already told you that this was going against our policy. The QA check does exactly what it needs to do. --=20 Mathieu Arnold --ffgbtnlwq2dnztg4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAltqt4xfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjiVw/+LDCB1hX5K/wWbOYyOqdVZv5SspPuBj9z8H5F9PLDFxqLB2fl2GRhwPor 1Ggm28iWFGkiWCKxsLSSWrkXtD9CoIdbzfsL+65qBjDdPU1r1aA+ZP3tbXcA+TI+ NOlk/90BquBNzDeTzTF7ArbcDidZZO0HpcCB86slKXfLVmHDNf2RhiE3csaom55D bhL9niDX3aq5gGqsFoqeUSrhWWgKoWBoE+84w+Khh4fIctiJcuGI2x+fUkoYJVq3 TGQ6eU/efcRrKWXkO4Ni0qc4m/JhPXG+fazBA4o12TCQUZE+E0rOOHJ7LAIsBTat i0SNFPuQ2/qD7nbASxFTqutv+mouyrWz5kL6I/cKP3Sk9eR6nfFdytrivth7wf2J kV+0H8l8PS/99XXjD8Ge7NMEyUnB5cuRx4uXgRYPsu+ecej0MEUiUsd9kbbgHu5q rnwY57q6L6AfsWvX90Uti38NosNz5USbrTAZWJ/TMAebsO8XfAabTLnN/6ffp1IR Fj+zaKkrHSrLxYptNnAcmoxVHut5abfKNwOL6RtrkiGL3egKrZEJviK8kOjcmShM KrBx3juVdJR+aGvlkmr9z8nX/oYYmGsIpVrXrnLYgivfkcSSk0vhx1NCkvn2fk5z kqJnEhr3IlefIbBd8IidbR5d7hfO8gMExH02uENCcLrhr6ujo8s= =ybfs -----END PGP SIGNATURE----- --ffgbtnlwq2dnztg4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180808092741.3mwliq4lippwbwrz>