From owner-svn-src-head@freebsd.org Sun May 19 21:05:30 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D387C1591F49; Sun, 19 May 2019 21:05:30 +0000 (UTC) (envelope-from ota@j.email.ne.jp) Received: from mail01.asahi-net.or.jp (mail01.asahi-net.or.jp [202.224.55.13]) by mx1.freebsd.org (Postfix) with ESMTP id 5731F74C76; Sun, 19 May 2019 21:05:29 +0000 (UTC) (envelope-from ota@j.email.ne.jp) Received: from vmware.advok.com (pool-72-76-119-135.nwrknj.fios.verizon.net [72.76.119.135]) (Authenticated sender: NR2Y-OOT) by mail01.asahi-net.or.jp (Postfix) with ESMTPSA id 6BF78121025; Mon, 20 May 2019 06:05:17 +0900 (JST) Date: Sun, 19 May 2019 17:04:17 -0400 From: Yoshihiro Ota To: Konstantin Belousov Cc: ota@j.email.ne.jp, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r347968 - head/sys/kern Message-Id: <20190519170417.b05e8c43b2ccf9a6826a1d21@j.email.ne.jp> In-Reply-To: <20190519175104.GP2748@kib.kiev.ua> References: <201905190918.x4J9IAs1036579@repo.freebsd.org> <20190519115228.49fdc5c833c2abe06f894dc2@j.email.ne.jp> <20190519175104.GP2748@kib.kiev.ua> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; i386-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5731F74C76 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.950,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 May 2019 21:05:31 -0000 Hi Konstantin, I coundn't remount ro->rw a few days ago. This change isn't related, then. I will check/tesst it again later, then. Thanks, Hiro On Sun, 19 May 2019 20:51:04 +0300 Konstantin Belousov wrote: > On Sun, May 19, 2019 at 11:52:28AM -0400, Yoshihiro Ota wrote: > > Hi, > > > > Does this change fix 'mount -u -rw /path' to remount read-only device with write mode? > > I moticed an issue a couple of days ago but didn't have time to conform nor report. > > I do not understand your description. If you mean does this commit has > any relevance to the issue of remounting ro->rw, it should not. It only > affects rw->ro remounts, when you have a binary executed from the mount > point. > > > > > Thanks, > > Hiro > > > > On Sun, 19 May 2019 09:18:10 +0000 (UTC) > > Konstantin Belousov wrote: > > > > > Author: kib > > > Date: Sun May 19 09:18:09 2019 > > > New Revision: 347968 > > > URL: https://svnweb.freebsd.org/changeset/base/347968 > > > > > > Log: > > > Fix rw->ro remount when there is a text vnode mapping. > > > > > > Reported and tested by: hrs > > > Sponsored by: The FreeBSD Foundation > > > MFC after: 16 days > > > > > > Modified: > > > head/sys/kern/vfs_subr.c > > > > > > Modified: head/sys/kern/vfs_subr.c > > > ============================================================================== > > > --- head/sys/kern/vfs_subr.c Sun May 19 06:01:11 2019 (r347967) > > > +++ head/sys/kern/vfs_subr.c Sun May 19 09:18:09 2019 (r347968) > > > @@ -3146,7 +3146,7 @@ loop: > > > > > > if ((vp->v_type == VNON || > > > (error == 0 && vattr.va_nlink > 0)) && > > > - (vp->v_writecount == 0 || vp->v_type != VREG)) { > > > + (vp->v_writecount <= 0 || vp->v_type != VREG)) { > > > VOP_UNLOCK(vp, 0); > > > vdropl(vp); > > > continue; > > > _______________________________________________ > > > svn-src-all@freebsd.org mailing list > > > https://lists.freebsd.org/mailman/listinfo/svn-src-all > > > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"