From owner-svn-ports-head@FreeBSD.ORG Mon Aug 11 07:50:44 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9DE5A5E6; Mon, 11 Aug 2014 07:50:44 +0000 (UTC) Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.issp.ac.ru", Issuer "relay.issp.ac.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 053652B92; Mon, 11 Aug 2014 07:50:43 +0000 (UTC) Received: from mercury.issp.ac.ru [77.236.34.155:8003] (HELO/EHLO mercury.ph.man.ac.uk, authenticated with PLAIN) by mail.issp.ac.ru with ESMTP/inet id s7B7p3jW039269 (using TLSv1/SSLv3, with cipher DHE-RSA-AES256-SHA (256 bits), verified NO) Mon, 11 Aug 2014 11:51:03 +0400 (MSK) X-Authentication-Warning: mail.issp.ac.ru: Host mercury.issp.ac.ru [77.236.34.155] claimed to be mercury.ph.man.ac.uk From: Max Brazhnikov To: Alexey Dokuchaev Subject: Re: svn commit: r364518 - in head: accessibility/py-papi audio/py-al devel/py-astroid devel/py-dynrules devel/py-game devel/py-logilab-common devel/py-ocempgui devel/py-ply devel/py-sdl2 devel/pychecke... Date: Mon, 11 Aug 2014 07:50:40 +0000 Message-ID: <1541578.rWvlqK3ZQn@mercury.ph.man.ac.uk> User-Agent: KMail/4.12.5 (FreeBSD/9.3-PRERELEASE; KDE/4.12.5; amd64; ; ) In-Reply-To: <20140810164416.GA43983@FreeBSD.org> References: <53e7336d.2c4d.2257f090@svn.freebsd.org> <2556564.WKGpsAPjlp@mercury.ph.man.ac.uk> <20140810164416.GA43983@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Marcus von Appen , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Aug 2014 07:50:44 -0000 On Sun, 10 Aug 2014 16:44:16 +0000 Alexey Dokuchaev wrote: > On Sun, Aug 10, 2014 at 03:40:11PM +0000, Max Brazhnikov wrote: > > On Sun, 10 Aug 2014 09:55:16 +0000 Alexey Dokuchaev wrote: > > > On Sun, Aug 10, 2014 at 08:55:08AM +0000, Marcus von Appen wrote: > > > > New Revision: 364518 > > > > URL: http://svnweb.freebsd.org/changeset/ports/364518 > > > > QAT: https://qat.redports.org/buildarchive/r364518/ > > > > > > > > -USES= pkgconfig > > > > +USES= pkgconfig python:2 > > > > USE_GNOME= atk > > > > -USE_PYTHON= 2 > > > > -USE_PYDISTUTILS=yes > > > > -PYDISTUTILS_AUTOPLIST= yes > > > > +PYTHON_FEATURES=autoplist distutils > > > > > > Yuck, this PYTHON_FEATURES knob is ugly. Why not follow Perl's example > > > instead (USES=perl and USE_PERL)? It both makes more sense and shorter. > > > > ugly or not, it's a matter of taste. [...] > > Not really. It is also 1) inconsistent with USE_PERL, and 2) is overly > long knob name (breaks indentation). 1) I don't think USE_PERL is worthy of comparison, USE_XXX shouldn't be used after conversion to USES: - it complicates the transition - it's inconsistent with other old style USE_YXZ I'd like to see something like XXX_COMPONENTS for this, but it is too long :) 2) I'd prefer broken indentation to clear meaning. > ../danfe > > P.S. I'm wondering about these "a matter of taste" reasons. Are you > guys really don't see the ugliness when it's there? Why defending it > when it can/should be just fixed? I don't defend it. I just dislike it for different reasons than you :) Max