Date: Wed, 2 Aug 1995 09:22:39 +0400 (MSD) From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= aka "Andrey A. Chernov, Black Mage" <ache@astral.msk.su> To: CVS-commiters@freefall.cdrom.com, Bruce Evans <bde@zeta.org.au>, cvs-sys@freefall.cdrom.com Subject: Re: cvs commit: src/sys/kern tty.c tty_compat.c Message-ID: <hCVkm7muK1@astral.msk.su> In-Reply-To: <199508020008.KAA09830@godzilla.zeta.org.au>; from Bruce Evans at Wed, 2 Aug 1995 10:08:12 %2B1000 References: <199508020008.KAA09830@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199508020008.KAA09830@godzilla.zeta.org.au> Bruce Evans
writes:
>> Modified: sys/kern tty.c tty_compat.c
>> Log:
>> Check for valid speeds in TIOCSET* and return EINVAL for incorrect
>> values instead of setting garbadge.
>All speeds between 1 and LONG_MAX are valid. Some drivers support
0 here
>setting speeds that can't be handled by tty_compat. E.g., the cy
>driver allows 76800 and 150000 and many others. Handling these
>is a problem for tty_compat and crufty applications, not for the
>termios driver.
Ok, I'll left only check for negative values in tty.c
>All h/w tty drivers (except iitty :-() do their own speed checking.
>Perhaps the pty driver should only allow the standard speeds.
And move this checking into pty driver.
--
Andrey A. Chernov : And I rest so composedly, /Now, in my bed,
ache@astral.msk.su : That any beholder /Might fancy me dead -
FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead.
RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?hCVkm7muK1>