Date: Wed, 15 Nov 2017 15:52:06 +0000 (UTC) From: Alan Somers <asomers@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r325857 - head/sys/cam Message-ID: <201711151552.vAFFq6vW033718@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: asomers Date: Wed Nov 15 15:52:06 2017 New Revision: 325857 URL: https://svnweb.freebsd.org/changeset/base/325857 Log: Remove a double free(9) in xpt_bus_register In xpt_bus_register(), remove superfluous call to free(). This was mostly benign since free(9) checks for NULL before doing anything, and xpt_create_path() is nice enough to NULL out the pointer on failure. However, it could've segfaulted if malloc(9) failed during xpt_create_path(). Submitted by: gibbs MFC after: 3 weeks Sponsored by: Spectra Logic Corp Modified: head/sys/cam/cam_xpt.c Modified: head/sys/cam/cam_xpt.c ============================================================================== --- head/sys/cam/cam_xpt.c Wed Nov 15 15:24:28 2017 (r325856) +++ head/sys/cam/cam_xpt.c Wed Nov 15 15:52:06 2017 (r325857) @@ -4049,7 +4049,6 @@ xpt_bus_register(struct cam_sim *sim, device_t parent, CAM_TARGET_WILDCARD, CAM_LUN_WILDCARD); if (status != CAM_REQ_CMP) { xpt_release_bus(new_bus); - free(path, M_CAMXPT); return (CAM_RESRC_UNAVAIL); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201711151552.vAFFq6vW033718>