From owner-svn-ports-head@FreeBSD.ORG  Mon Aug 25 13:55:32 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1103D729;
 Mon, 25 Aug 2014 13:55:32 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C8D8A3E3A;
 Mon, 25 Aug 2014 13:55:31 +0000 (UTC)
Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca
 [108.170.169.12])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by apnoea.adamw.org (Postfix) with ESMTPSA id 98C2B73014;
 Mon, 25 Aug 2014 09:55:29 -0400 (EDT)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: svn commit: r365735 - in head/games: . prboom-plus
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <53FB3FB3.90508@marino.st>
Date: Mon, 25 Aug 2014 09:55:28 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <9A340EAF-EEDD-4D38-B4D8-5FD3C2C9EED7@adamw.org>
References: <201408231404.s7NE4Ds7036892@svn.freebsd.org>
 <20140825093243.GC66191@FreeBSD.org>
 <F714F3E9-01A2-4D60-99D3-7EA6136CFF75@adamw.org> <53FB3FB3.90508@marino.st>
To: marino@freebsd.org
X-Mailer: Apple Mail (2.1878.6)
Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>,
 Adam Weinberger <adamw@FreeBSD.org>, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Aug 2014 13:55:32 -0000

On 25 Aug, 2014, at 9:52, John Marino <freebsd.contact@marino.st> wrote:

> On 8/25/2014 15:43, Adam Weinberger wrote:
>> On 25 Aug, 2014, at 5:32, Alexey Dokuchaev <danfe@FreeBSD.org>
>> wrote:
>>> COMMENT line is wrong. :)
>>=20
>> Because it starts with an article? I=92d posit that that article
>> improves readability of this particular COMMENT.
>=20
> Yes, because it starts with an article.   We've been instructed to
> remove them unconditionally.
> Hundreds of ports have comments equivalent to "Fork of the doom game
> engine prboom", so it's not special in any way.
>=20
> Unfortunately portlint doesn't check for this.  I'd add this to the
> current catch-all portlint rule PR.

Guys, if it=92s not right, please just fix it!

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org