Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 20 Jan 2006 14:27:57 +0300
From:      Sergey Skvortsov <skv@FreeBSD.org>
To:        Edwin Groothuis <edwin@mavetju.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/net/ssldump/files patch-ssl%ssldecode.c
Message-ID:  <43D0C93D.1050704@FreeBSD.org>
In-Reply-To: <20060120105326.GC1026@k7.mavetju>
References:  <200601201014.k0KAEMQ5053386@repoman.freebsd.org> <20060120102934.GB1026@k7.mavetju> <43D0BE68.6010403@FreeBSD.org> <20060120105326.GC1026@k7.mavetju>

next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Edwin Groothuis wrote:
>>
>> Edwin Groothuis wrote:
>>>>   FreeBSD ports repository
>>>>
>>>>   Added files:
>>>>     net/ssldump/files    patch-ssl%ssldecode.c 
>>> Did I miss a naming-convention change?
>
>> History repeats itself... Ok.
>>
>> 1. I dislike "_" as path delimiter. It's not so obvious and aesthetic as
>> "::" or "%".
> 
> I don't like it neither, but I accepted the fact that there was a
> proper naming standard for it so at least this wildgrowth of patch
> files would be resolved.

First of all, it is not a "proper naming standard". I always suggest to
use SHOULD/MUST/etc words (RFC 2119) in "Porters' Handboook" to avoid
any incomprehension. In current situation I prefer to treat "Please only
use characters [-+._a-zA-Z0-9]" as "You SHOULD use characters
[-+._a-zA-Z0-9]".

Many committers do not like this "convention". Hence the above regex
should be reviewed and extended. There is no technical problems with
additional ":%" symbols. Patch names must be convenient, not procrustean.

- --
Sergey Skvortsov
mailto: skv@FreeBSD.org
-----BEGIN PGP SIGNATURE-----

iD8DBQFD0Mk9RInQ7WebgRkRAlS5AJ0TO9btRCT4uaeMk0P2tn4u4WfvCACcC3zW
nwaaMoJFN4rJk6nZT64E9Fk=
=10yq
-----END PGP SIGNATURE-----



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43D0C93D.1050704>