From owner-cvs-all Thu Mar 7 4:10:45 2002 Delivered-To: cvs-all@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id 81C0237B405; Thu, 7 Mar 2002 04:10:40 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g27CAdE52226; Thu, 7 Mar 2002 12:10:39 GMT (envelope-from mark@grimreaper.grondar.za) Received: from grimreaper (localhost [127.0.0.1]) by grimreaper.grondar.org (8.12.2/8.12.2) with ESMTP id g27C6nRV009991; Thu, 7 Mar 2002 12:06:49 GMT (envelope-from mark@grimreaper.grondar.za) Message-Id: <200203071206.g27C6nRV009991@grimreaper.grondar.org> To: obrien@FreeBSD.org Cc: Will Andrews , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c References: <20020307032014.B63863@dragon.nuxi.com> In-Reply-To: <20020307032014.B63863@dragon.nuxi.com> ; from "David O'Brien" "Thu, 07 Mar 2002 03:20:14 PST." Date: Thu, 07 Mar 2002 12:06:49 +0000 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > In my opinion, the above change makes the code clearer. The > > previous construct obfuscates the logic. > > 1. that is not sufficient reason to arbitrarily change working code. Content free statement. Taking this stament seriously means clarifying code is not possible. > 2. please review the C idiom of short-circuit evaluation. I know this. See style(9) on complicated expressions. M -- o Mark Murray \_ O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message