Date: Mon, 26 Sep 2011 16:12:55 +0200 From: "K. Macy" <kmacy@freebsd.org> To: Arnaud Lacombe <lacombar@gmail.com> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, dave jones <s.dave.jones@gmail.com> Subject: Re: Kernel panic on FreeBSD 9.0-beta2 Message-ID: <CAHM0Q_PZD9_0ZkELZ5XL8Ebh8eD-uFuSjXWKKVpGDeM_JDaqMA@mail.gmail.com> In-Reply-To: <CACqU3MU9ZZtOsdBOa%2BF3SqUaYgO%2BEo0v1ACjY0S4rY4fRQyv5Q@mail.gmail.com> References: <CANf5e8aG4go4M_vsRExUsJB_sjaN5x-QK-TCDAhSH64JSo0mdQ@mail.gmail.com> <CACqU3MXStMMEoppvDtZS6hV4WGttbdJiF8E-ORwJ%2BQSmnTy-Yg@mail.gmail.com> <CACqU3MV-t4Va6VWUoXy1Y9FYnNJTUw1X%2BE7ik-2%2BtMVuVOV3RA@mail.gmail.com> <CAJ-Vmom-177OkdUXjz%2BZLqbaqn=p%2BuTGypiVuMqdeXgdOgb4hQ@mail.gmail.com> <CAHM0Q_Mmn3z1V6AtZHQMpgbdY7oQqOChiNt=8NJrZQDnravb7A@mail.gmail.com> <CACqU3MU9ZZtOsdBOa%2BF3SqUaYgO%2BEo0v1ACjY0S4rY4fRQyv5Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry, didn't look at the images (limited bw), I've seen something like this before in timewait. This "can't happen" with UDP so will be interested in learning more about the bug. On Mon, Sep 26, 2011 at 4:02 PM, Arnaud Lacombe <lacombar@gmail.com> wrote: > Hi, > > On Mon, Sep 26, 2011 at 5:12 AM, K. Macy <kmacy@freebsd.org> wrote: >> >> >> On Monday, September 26, 2011, Adrian Chadd <adrian@freebsd.org> wrote: >>> On 26 September 2011 13:41, Arnaud Lacombe <lacombar@gmail.com> wrote: >>>> =A0/* >>>> =A0 * XXX >>>> =A0 * This entire block sorely needs a rewrite. >>>> =A0 */ >>>> =A0 =A0 =A0 =A0if (t && >>>> =A0 =A0 =A0 =A0 =A0 =A0((t->inp_flags & INP_TIMEWAIT) =3D=3D 0) && >>>> =A0 =A0 =A0 =A0 =A0 =A0(so->so_type !=3D SOCK_STREAM || >>>> =A0 =A0 =A0 =A0 =A0 =A0 ntohl(t->inp_faddr.s_addr) =3D=3D INADDR_ANY) = && >>>> =A0 =A0 =A0 =A0 =A0 =A0(ntohl(sin->sin_addr.s_addr) !=3D INADDR_ANY || >>>> =A0 =A0 =A0 =A0 =A0 =A0 ntohl(t->inp_laddr.s_addr) !=3D INADDR_ANY || >>>> =A0 =A0 =A0 =A0 =A0 =A0 (t->inp_socket->so_options & >>>> =A0 =A0 =A0 =A0 =A0 SO_REUSEPORT) =3D=3D 0) && >>>> =A0 =A0 =A0 =A0 =A0 =A0(inp->inp_cred->cr_uid !=3D >>>> =A0 =A0 =A0 =A0 =A0 =A0 t->inp_cred->cr_uid)) >>>> =A0 =A0 =A0 =A0 =A0return (EADDRINUSE); >>>> =A0 =A0 =A0} >>>> >>>> more specifically, `t->inp_socket' is NULL. The top comment may not be >>>> relevant, as it's been here for the past 8 years. >>> >>> Why would t->inp_socket be NULL at this point? >> >> TIME_WAIT ... >> > on UDP socket ? > > =A0- Arnaud >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHM0Q_PZD9_0ZkELZ5XL8Ebh8eD-uFuSjXWKKVpGDeM_JDaqMA>