Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 May 2010 10:21:02 +0300
From:      keramida@freebsd.org (Giorgos Keramidas)
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        cvs-ports@freebsd.org, Hajimu UMEMOTO <ume@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/editors/emacs Makefile
Message-ID:  <87y6fc1jxd.fsf@kobe.laptop>
In-Reply-To: <20100522063751.GA87869@FreeBSD.org> (Alexey Dokuchaev's message of "Sat, 22 May 2010 06:37:51 %2B0000")
References:  <201005211951.o4LJp46e084250@repoman.freebsd.org> <yge1vd4h5zr.wl%ume@mahoroba.org> <87bpc832m4.fsf@kobe.laptop> <20100522063751.GA87869@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 22 May 2010 06:37:51 +0000, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> On Sat, May 22, 2010 at 08:52:03AM +0300, Giorgos Keramidas wrote:
>> Does this patch look ok?
>
> No, it does not.  PORTEPOCH could never go backwards or be reset.  It is
> the way we deal when version scheme changes so "newer" version is less
> than "old", or when for some reason port must be downgraded (yes, these
> things happen from time to time).
>
> You should have bumped PORTREVISION (wraps every version update, thus
> being cheap), but now it's probably too late: accidental errors like
> this should normally be reverted in a matter of minutes.
>
> Please refer to relevant PHB chapters for gory details, and be careful
> next time.

Argh.  So can we just commit the bsd.port.pre.mk bits?  The OSVERSION
check is important for 6.X users.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87y6fc1jxd.fsf>