From owner-cvs-ports@FreeBSD.ORG Sat May 22 07:21:29 2010 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 123D31065676; Sat, 22 May 2010 07:21:29 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 7756F8FC23; Sat, 22 May 2010 07:21:28 +0000 (UTC) X-Spam-Status: No X-Hellug-MailScanner-From: keramida@freebsd.org X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-0.2, required 5, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_50 0.80) X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-ID: o4M7L3DI013849 Received: from kobe.laptop (ppp-94-64-244-40.home.otenet.gr [94.64.244.40]) (authenticated bits=128) by igloo.linux.gr (8.14.3/8.14.3/Debian-9.1) with ESMTP id o4M7L3DI013849 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 22 May 2010 10:21:18 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.4/8.14.4) with ESMTP id o4M7L2l7068279 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 22 May 2010 10:21:03 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.14.4/8.14.4/Submit) id o4M7L29F068276; Sat, 22 May 2010 10:21:02 +0300 (EEST) (envelope-from keramida@freebsd.org) From: keramida@freebsd.org (Giorgos Keramidas) To: Alexey Dokuchaev References: <201005211951.o4LJp46e084250@repoman.freebsd.org> <87bpc832m4.fsf@kobe.laptop> <20100522063751.GA87869@FreeBSD.org> Date: Sat, 22 May 2010 10:21:02 +0300 In-Reply-To: <20100522063751.GA87869@FreeBSD.org> (Alexey Dokuchaev's message of "Sat, 22 May 2010 06:37:51 +0000") Message-ID: <87y6fc1jxd.fsf@kobe.laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: cvs-ports@freebsd.org, Hajimu UMEMOTO , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/editors/emacs Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 May 2010 07:21:29 -0000 On Sat, 22 May 2010 06:37:51 +0000, Alexey Dokuchaev wrote: > On Sat, May 22, 2010 at 08:52:03AM +0300, Giorgos Keramidas wrote: >> Does this patch look ok? > > No, it does not. PORTEPOCH could never go backwards or be reset. It is > the way we deal when version scheme changes so "newer" version is less > than "old", or when for some reason port must be downgraded (yes, these > things happen from time to time). > > You should have bumped PORTREVISION (wraps every version update, thus > being cheap), but now it's probably too late: accidental errors like > this should normally be reverted in a matter of minutes. > > Please refer to relevant PHB chapters for gory details, and be careful > next time. Argh. So can we just commit the bsd.port.pre.mk bits? The OSVERSION check is important for 6.X users.