From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Feb 26 18:00:01 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 531F0B5B
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Wed, 26 Feb 2014 18:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3FA3215C6
 for <freebsd-ports-bugs@smarthost.ysv.freebsd.org>;
 Wed, 26 Feb 2014 18:00:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id s1QI01kQ026885
 for <freebsd-ports-bugs@freefall.freebsd.org>; Wed, 26 Feb 2014 18:00:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s1QI01IF026884;
 Wed, 26 Feb 2014 18:00:01 GMT (envelope-from gnats)
Date: Wed, 26 Feb 2014 18:00:01 GMT
Message-Id: <201402261800.s1QI01IF026884@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
Cc: 
From: Antoine Brodin <antoine@FreeBSD.org>
Subject: Re: ports/186982: [PATCH] net/xorp: update to 1.8.5
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: Antoine Brodin <antoine@FreeBSD.org>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Feb 2014 18:00:01 -0000

The following reply was made to PR ports/186982; it has been noted by GNATS.

From: Antoine Brodin <antoine@FreeBSD.org>
To: bug-followup@FreeBSD.org, joemann@beefree.free.de
Cc:  
Subject: Re: ports/186982: [PATCH] net/xorp: update to 1.8.5
Date: Wed, 26 Feb 2014 18:57:55 +0100

 Hi,
 
 There are some problems with your patch:
 - PORTREVISION=0 can be removed
 - you can use DISTVERSIONSUFFIX= -src
 - MAKE_JOBS_SAFE is obsolete
 - your patch replaces use of OPTIONS with obsolete WITH/WITHOUT
 - USE_OPENSSL has to stay, some people build base without it
 - USE_SCONS is deprecated, it should be USES= scons
 - rc script name is changed to .sh ,  this is obsolete
 - should use GROUPS= to create the group instead of a
 pkg-install/pkg-deinstall script (this was already a problem before)
 - you can remove the post-install part, it's not necessary with staging
 - /usr/local seems hardcoded in some patches, this is not pretty
 
 Cheers,
 
 Antoine