From owner-svn-src-head@freebsd.org Fri Feb 19 04:53:21 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5CD7EAAD3A8; Fri, 19 Feb 2016 04:53:21 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 25F491554; Fri, 19 Feb 2016 04:53:21 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x233.google.com with SMTP id g203so98008866iof.2; Thu, 18 Feb 2016 20:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=aCJ9XkfLo6Ktt+mxerRMieEmE/itAhicsdml3vZrfco=; b=xBnV8tPNWCsLUY7vFeifJLKiqEKzy9YL8Cq2DMRMSw++eVMvrw3a/F4OEMT6P6avf+ Ln5YsvS0g2IQVNX52ougMyMnzMdPtY4B2SHCun17ciifaPh4rQG2RpHUUVBcQyXgtIKN 0kR8NxctfrV9FJg6XbV06/D7XYNYyzwksbJ/yFoseCVZissKPcBzzcy3NuW5Q2nI8T1M Kf8pQmtXnoBDNNXGVOD8tm5h0ELsS59C7rmRuFAhQQRkiUNCif+rxglnMk822a1iP5mA LHQmOS4tmxsoD74y3KuEzUKxuIYoLQOhPxvvTucfBNBtWPaSCkDi/hpgKShXBeJaEYdk moNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=aCJ9XkfLo6Ktt+mxerRMieEmE/itAhicsdml3vZrfco=; b=SiZ6gMGCIUmjj8E+ky14xxJ7ufte4hjSD0CGk2/gOt2oBoAvu8ck19Ug5Zofr0QYMr z+TLGumIRPuYXg4kWN8MNanCJia3kGtffbIlLlr9ywVxY3ajiZ1Tgq8WxzXm6ciRhsZT wkWAlpv0Z7wlQlD0vdWBTi+ArLSqgC6XlgzFoeJFSboj0LQfl3smRwRWSsdQMnZFfJ05 gA4HVHOfo3DXwF3YP+0VUFECqHdINhthBg1MG1Lu4OxiZirqR2f6GT5AHS171ATyZagZ bdavQ7McJPz+A7Z54PjYLOofVEDnJZC7um1SIFsqH+0+/1Io3Yql7cA3XV+ryJEpdJi7 Uo5w== X-Gm-Message-State: AG10YOT0cuOkySFOQcYsscsOCEbjdaX/y4CGa/2ojyKvvnKGrAN0u/wKkEldQpACjUrMemAlGfMS2ifUQ4FDAw== MIME-Version: 1.0 X-Received: by 10.107.162.144 with SMTP id l138mr12039940ioe.123.1455857600409; Thu, 18 Feb 2016 20:53:20 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.14.19 with HTTP; Thu, 18 Feb 2016 20:53:20 -0800 (PST) In-Reply-To: References: <56C66415.7040407@FreeBSD.org> Date: Thu, 18 Feb 2016 20:53:20 -0800 X-Google-Sender-Auth: R08Vv40rBVRj6x7cu7YEVpRbTDc Message-ID: Subject: Re: svn commit: r229537 - in head/sys: conf geom/uncompress modules/geom/geom_uncompress From: Adrian Chadd To: Maxim Sobolev Cc: Bryan Drewery , Aleksandr Rybalko , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 04:53:21 -0000 It passed the "it's working code and it's immediately useful" filter. I'd love to see them both unified somehow. I really would! -a On 18 February 2016 at 17:28, Maxim Sobolev wrote: > Sigh, I don't now how it managed to sleep through usually tight FreeBSD > peer-review process. It would be interesting to hear some comments from @ray > and @adrian, perhaps there were some reasons for it being done this way, > although I cannot see any in a hindsight. > > I am just in the middle of rather substantial overhaul of both kernel and > userland part here: > > https://reviews.freebsd.org/D5333 > > And once that committed it will take them apart again. I've also spend quite > lot of time testing my change set, which would with very little effort have > covered both formats had I started with unified code base. :( > > I also plan on making further improvement into kernel module, as it is right > now both g_uzip and g_uncompress basically piggyback single "g_up" thread, > so you cannot use multiple cores even for different instances, let alone one > instance being accessed by multiple readers. And it also can delay other > unrelated I/O requests by maxing out CPU time slice available for the g_up. > > On Thu, Feb 18, 2016 at 4:38 PM, Bryan Drewery wrote: >> >> On 2/18/2016 3:57 PM, Maxim Sobolev wrote: >> > Aleksandr, Adrian, >> > >> > I know it's 3 years later, but I really don't know why it's been done >> > this way. Take a GEOM module and associated usr.bin utility, copy it >> > verbatim add few lines of code and re-add that as a new module seems >> > like just laziness and attempt to avoid doing extra work on making >> > unified code. The same goes for the mkulzma, which is almost 1:1 copy of >> > the mkuzip. Now people are merging back and forth and I've just spent >> > few days testing some rather major rework of geom_uzip / mkuzip code not >> > even realizing that there is its evil twin in the tree. :( >> >> r283104 is an example of one of these problems. It was a catch-up of >> uzip's r268986 done almost a year before. I did comparisons before using >> uzip last summer and ran across that one. >> >> > >> > https://reviews.freebsd.org/D5333 >> > >> > I suggest functionality from both geom_uncompress / mkulzma are folded >> > now back into geom_uzip / mkuzip and geom_uncompress / mkulzma are nuked >> > afterwards. >> > >> > Thanks! >> > >> > >> > >> > Author: ray >> > Date: Wed Jan 4 23:39:11 2012 >> > New Revision: 229537 >> > URL: http://svn.freebsd.org/changeset/base/229537 >> > Log: >> > GEOM_UNCOMPRESS module, can be used with uzip images and with new >> > ulzma images. >> > Approved by: adrian (mentor) >> > Added: >> > head/sys/geom/uncompress/ >> > head/sys/geom/uncompress/g_uncompress.c (contents, props changed) >> > head/sys/modules/geom/geom_uncompress/ >> > head/sys/modules/geom/geom_uncompress/Makefile (contents, props >> > changed) >> > Modified: >> > head/sys/conf/files >> > head/sys/conf/options >> > >> > >> >> >> -- >> Regards, >> Bryan Drewery >> > > > > -- > Maksym Sobolyev > Sippy Software, Inc. > Internet Telephony (VoIP) Experts > Tel (Canada): +1-778-783-0474 > Tel (Toll-Free): +1-855-747-7779 > Fax: +1-866-857-6942 > Web: http://www.sippysoft.com > MSN: sales@sippysoft.com > Skype: SippySoft