Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 May 1999 17:08:24 -0700 (PDT)
From:      Archie Cobbs <archie@whistle.com>
To:        phk@critter.freebsd.dk (Poul-Henning Kamp)
Cc:        leifn@neland.dk, bob@dnsdata.com, freebsd-current@FreeBSD.org
Subject:   Re: Skip fail under current, was: Re: VPN betwwen Windows 9x Clients and FreeBSD Firewall
Message-ID:  <199905160008.RAA04068@bubba.whistle.com>
In-Reply-To: <19502.926767996@critter.freebsd.dk> from Poul-Henning Kamp at "May 15, 99 01:33:16 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp writes:
> >It won't compile under current.
> >freebsd/skip_es.c breaks at
> >
> >	if (suser(p->p_ucred, &p->p_acflag )) {
> >
> >This won't compile, because suser only has one parameter.
> >
> >Trying blindly to change it to: 
> >
> >	if (suser(p->p_ucred)) {
> 
> Better yet, read the manpage for suser(9) and change it to:
> 
> 	if (suser(p)) {

Thanks for noticing this. I'll fix it as soon as the ports freeze is over.
For the sake of 3.x systems, I'll change it to this..

    #if __FreeBSD_version < 400005
	    if (suser(p->p_ucred, &p->p_acflag )) {
    #else
	    if (suser(p)) {
    #endif
		    return (EPERM);
	    }

Poul, thanks for bumping __FreeBSD_version when the suser() changes
went through :-)

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199905160008.RAA04068>