Date: Sat, 10 Jan 2009 16:40:02 GMT From: Andriy Gapon <avg@icyb.net.ua> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/100513: [smbus] Inconsistent definition of SMBus addresses in SMBus drivers Message-ID: <200901101640.n0AGe2nU086306@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/100513; it has been noted by GNATS. From: Andriy Gapon <avg@icyb.net.ua> To: bug-followup@FreeBSD.org, arthur.hartwig@nokia.com Cc: Subject: Re: kern/100513: [smbus] Inconsistent definition of SMBus addresses in SMBus drivers Date: Sat, 10 Jan 2009 18:34:49 +0200 I've encountered the same problem while migrating some code from a platform using intpm to a platform with ichsmb. I looked through the code and it seems that ichsmb is the only driver that explicitly shifts slave address. All others seem to pass slave address as-is to the hardware. But there might be some subtleties - some hardware might expect the address to be in "unshifted" form. Arthur, if you are still interested and can verify this, are you sure that amdpm driver expects address to be in "unshifted" form (0x55 in your example)? I'd rather expect ichsmb to be the only "black sheep". -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901101640.n0AGe2nU086306>