From owner-svn-src-head@FreeBSD.ORG Fri Sep 6 10:43:13 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 84664CAE; Fri, 6 Sep 2013 10:43:13 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 51A4220DB; Fri, 6 Sep 2013 10:43:12 +0000 (UTC) Received: from [192.168.0.2] (cpc27-cmbg15-2-0-cust235.5-4.cable.virginmedia.com [86.27.188.236]) (authenticated bits=0) by theravensnest.org (8.14.5/8.14.5) with ESMTP id r86Ah91r070564 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 6 Sep 2013 10:43:10 GMT (envelope-from theraven@FreeBSD.org) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: svn commit: r255297 - in head: include lib/libc/iconv lib/libiconv_modules From: David Chisnall In-Reply-To: <20130906103636.GF41229@kib.kiev.ua> Date: Fri, 6 Sep 2013 11:43:04 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <81E1EB28-814E-491B-B3C9-90B17CDF189D@FreeBSD.org> References: <201309060946.r869kj8T064459@svn.freebsd.org> <20130906103636.GF41229@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1508) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 10:43:13 -0000 On 6 Sep 2013, at 11:36, Konstantin Belousov = wrote: > This is extremely rude. Such things are traditionally (and properly) > done with Makefile.inc in our tree. Look at the very beginning of > mk/bsd.init.mk. I was not aware of Makefile.inc, thank you. =20 > But the whole commit is hack. If you want to use C99 _Bool, use it = directly > instead of obfuscating the code through the build system. My intent was to minimise diffs from the citrus code. Our iconv.h leaks = stdbool.h into c89 files that use it, which is currently breaking around = a thousand ports (as would have been detected if there had been an exp = run before it was enabled by default). Removing this from the header = fixes the ports, but breaks the modules that expect bool to be defined. = This was the minimal change that would allow it to continue to build. The more elegant fix would be to modify all of the modules to explicitly = include stdbool.h if they wanted to use it, but this would then impose = lots more work on whoever does the next import from upstream. David (Who is currently trying to get the ports tree into a useable state for = 10.0)=