Date: Fri, 26 Oct 2007 14:04:21 -0700 (PDT) From: Doug Barton <dougb@FreeBSD.org> To: Pav Lucistnik <pav@FreeBSD.org> Cc: Bruce Cran <bruce@cran.org.uk>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/ataidle Makefile ports/sysutils/ataidle/files ataidle.in Message-ID: <alpine.BSF.0.9999.0710261403220.75470@qbhto.arg> In-Reply-To: <200710261338.l9QDcLQ0028796@repoman.freebsd.org> References: <200710261338.l9QDcLQ0028796@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 26 Oct 2007, Pav Lucistnik wrote: > pav 2007-10-26 13:38:21 UTC > > FreeBSD ports repository > > Modified files: > sysutils/ataidle Makefile > sysutils/ataidle/files ataidle.in > Log: > - Improve rc script > > PR: ports/117514 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=117514 > Submitted by: Bruce Cran <bruce@cran.org.uk> (maintainer) > > Revision Changes Path > 1.11 +1 -0 ports/sysutils/ataidle/Makefile > 1.3 +28 -16 ports/sysutils/ataidle/files/ataidle.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/ataidle/Makefile.diff?&r1=1.10&r2=1.11&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/ataidle/files/ataidle.in.diff?&r1=1.2&r2=1.3&f=h This is good work! The only thing I would change is to move the _start function above load_rc_config, but that's just a style issue. Thanks for taking the time to improve this. Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.0.9999.0710261403220.75470>