Skip site navigation (1)Skip section navigation (2)
Date:      11 Mar 2001 19:08:43 +0100
From:      Dag-Erling Smorgrav <des@ofug.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/alpha/linux linux_machdep.c
Message-ID:  <xzp7l1w2n6c.fsf@flood.ping.uio.no>
In-Reply-To: John Baldwin's message of "Mon, 5 Mar 2001 18:55:23 -0800 (PST)"
References:  <200103060255.f262tO937760@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin <jhb@FreeBSD.org> writes:
>   Log:
>   Create clone'd linux processes as stopped processes at first and don't
>   actually make them runnable until after the emulator layer has had a chance
>   to perform fixups.

This commit is wrong: rfork() masks away RFSTOPPED, so fork1() queues
the process, then linux_clone() queues it once again. This would have
gotten caught if runq_add() asserted that it didn't get passed an
already-queued process.

The corresponding commit to src/sys/alpha/linux/linux_machdep.c is of
course also incorrect.

DES
-- 
Dag-Erling Smorgrav - des@ofug.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzp7l1w2n6c.fsf>