From owner-freebsd-current@FreeBSD.ORG Wed Sep 23 17:09:41 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F1C47106566B for ; Wed, 23 Sep 2009 17:09:41 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.25]) by mx1.freebsd.org (Postfix) with ESMTP id A5E7E8FC1F for ; Wed, 23 Sep 2009 17:09:41 +0000 (UTC) Received: by qw-out-2122.google.com with SMTP id 5so130488qwd.7 for ; Wed, 23 Sep 2009 10:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=4aIzl2G/5xWO1yLtWerrzI8n7RuGI3VMGTeii4MtkSo=; b=CC/Xx8dSw3hVIU08fEDaJU8Ge1YIolUOXQyzAHJqcRMwYHv8KmdnFLxNFvqy0fCT25 5t9HCTbThXbGbzfWufgcoi9e2cN6rZwap10tvKyrxCPkkDiVLKFljzcSl6ovdy+jNqng R+3Y46B/6XFrXiGwtth76Fa+s+uOC15v0LKTk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=t3mQgV3tUb5cauNcxh3OmPaC5gWnZo68BPo4xbZS79k1bfxq3PV7laIOnYy9VoAjIr tOdU2yQEMCMXDR9Hm3+F+dI70wsPoq2HhiBang3Aj+dqStxu1iGslfD/mK07Y+QZ6RJd VtbKSwxYFDkJAMM78DaYBK/B7d9vzJFXf5VJc= Received: by 10.224.30.131 with SMTP id u3mr2170652qac.175.1253725780668; Wed, 23 Sep 2009 10:09:40 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id 8sm137702qwj.43.2009.09.23.10.09.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 23 Sep 2009 10:09:39 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Wed, 23 Sep 2009 10:08:52 -0700 From: Pyun YongHyeon Date: Wed, 23 Sep 2009 10:08:52 -0700 To: Grzegorz Bernacki Message-ID: <20090923170852.GA1099@michelle.cdnetworks.com> References: <20090922235350.GB1520@michelle.cdnetworks.com> <97F7ED67-AB93-4897-893B-16D3B22F9EB3@semihalf.com> <4ABA2C08.3070504@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ABA2C08.3070504@semihalf.com> User-Agent: Mutt/1.4.2.3i Cc: current@freebsd.org Subject: Re: mge, mii/e1000phy X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2009 17:09:42 -0000 On Wed, Sep 23, 2009 at 04:09:12PM +0200, Grzegorz Bernacki wrote: > >>From: Pyun YongHyeon > >>Date: 23 wrze?nia 2009 01:53:50 CEST > >>To: Kristof Provost > >>Cc: current@freebsd.org > >>Subject: Re: mge, mii/e1000phy > >>Reply-To: pyunyh@gmail.com > >> > >>>- Forcing the mge driver to IFM_100_TX (in mge_set_port_serial_control) > >>> does work. The system manages to acquire a DHCP address. > >> > >>Would you also show me the output of "ifconfig -m mge0"? > >> > >>I'm not author of mge(4) so I'm not familiar with mge(4). But it > >>seems that mge(4) lacks link state change handler. Normally NICs > >>are required to reprogram MAC to match resolved speed/duplex/ > >>flow-control of link when it know it established a valid link which > >>is notified from mii(4). > > > > Hi, > > You are right. Link state change handler is missing in mge(4) driver. It > is on our TODO list for this driver and will be implemented soon. > I've briefly looked over MV88F5182 opensource community programmer's user guide and found that ENQ bit of TQC register should be set again whenever link DOWN/UP event is detected which in turn may complicate the driver as it may have to reset its descriptor indexes. And I guess it's wrong to spin wait until link is established in mge_init_locked(). The datasheet says Rx checksum offloading capability but can't find more information for that. Another nice looking feature that lacks in mge(4) would be interrupt coalescing. And I guess interrupt coalescing feature would give better performance than polling(4). > grzesiek >