Date: Wed, 10 Apr 2013 18:53:14 +0000 (UTC) From: Neel Natu <neel@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r249342 - head/usr.sbin/bhyve Message-ID: <201304101853.r3AIrE83035930@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: neel Date: Wed Apr 10 18:53:14 2013 New Revision: 249342 URL: http://svnweb.freebsd.org/changeset/base/249342 Log: Remove obsolete comment about lack of locking for MMIO range lookup. Pointed out by: Tycho Nightingale (tycho.nightingale@plurisbusnetworks.com) Modified: head/usr.sbin/bhyve/mem.c Modified: head/usr.sbin/bhyve/mem.c ============================================================================== --- head/usr.sbin/bhyve/mem.c Wed Apr 10 18:13:33 2013 (r249341) +++ head/usr.sbin/bhyve/mem.c Wed Apr 10 18:53:14 2013 (r249342) @@ -30,12 +30,6 @@ * Memory ranges are represented with an RB tree. On insertion, the range * is checked for overlaps. On lookup, the key has the same base and limit * so it can be searched within the range. - * - * It is assumed that all setup of ranges takes place in single-threaded - * mode before vCPUs have been started. As such, no locks are used on the - * RB tree. If this is no longer the case, then a r/w lock could be used, - * with readers on the lookup and a writer if the tree needs to be changed - * (and per vCPU caches flushed) */ #include <sys/cdefs.h>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201304101853.r3AIrE83035930>