Date: Sun, 18 May 1997 13:24:25 -0700 From: David Greenman <dg@root.com> To: "Justin T. Gibbs" <gibbs@plutotech.com> Cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>, freebsd-bugs@hub.freebsd.org Subject: Re: kern/3618: getsockname and getpeername may cause trap 12 Message-ID: <199705182024.NAA27285@implode.root.com> In-Reply-To: Your message of "Sun, 18 May 1997 14:48:41 MDT." <199705181950.NAA19710@pluto.plutotech.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>> <<On Sun, 18 May 1997 15:08:52 +0200 (CEST), Tor Egge <Tor.Egge@idt.ntnu.no> >>said: >> >> > During the getsockname() or getpeername() call, a network interrupt >> > might reset the connection, causing the socket to no longer have a pcb. >> > If this happens at the wrong time, the system gets a trap 12. >> >> This fix looks OK. You have commit privs... > >I think that the splnet() and perhaps the other initializers should be >broken appart from the declarations since, as I recall, he compiler can >re-order the initializations if it doesn't see any interdependancies. >It would also make it clearer exactly which actions need splnet protection. I agree. It's the one thing that caught my eye immediately when I looked at the diff. -DG David Greenman Core-team/Principal Architect, The FreeBSD Project
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199705182024.NAA27285>