From owner-svn-ports-all@FreeBSD.ORG Sun Nov 25 22:36:50 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7BFBBCF2 for ; Sun, 25 Nov 2012 22:36:50 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 4C5DE8FC17 for ; Sun, 25 Nov 2012 22:36:50 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAPMaomN073409 for ; Sun, 25 Nov 2012 22:36:50 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAPMaohk073400 for svn-ports-all@freebsd.org; Sun, 25 Nov 2012 22:36:50 GMT (envelope-from bdrewery) Received: (qmail 65816 invoked from network); 25 Nov 2012 16:36:48 -0600 Received: from unknown (HELO ?10.10.0.115?) (freebsd@shatow.net@10.10.0.115) by sweb.xzibition.com with ESMTPA; 25 Nov 2012 16:36:48 -0600 Message-ID: <50B29D7D.1090309@FreeBSD.org> Date: Sun, 25 Nov 2012 16:36:45 -0600 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Wesley Shields Subject: Re: svn commit: r307565 - head/net/silc-client References: <201211191622.qAJGMZps097391@svn.freebsd.org> <20121120111700.GI71195@ithaqua.etoilebsd.net> <20121125032245.GB10784@atarininja.org> <20121125100824.GB33816@ithaqua.etoilebsd.net> In-Reply-To: <20121125100824.GB33816@ithaqua.etoilebsd.net> X-Enigmail-Version: 1.4.6 OpenPGP: id=3C9B0CF9; url=http://www.shatow.net/bryan/bryan.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB7E502E5F93026A47CB0CE73" Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2012 22:36:50 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB7E502E5F93026A47CB0CE73 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 11/25/2012 4:08 AM, Baptiste Daroussin wrote: > On Sat, Nov 24, 2012 at 10:22:45PM -0500, Wesley Shields wrote: >> On Tue, Nov 20, 2012 at 12:17:00PM +0100, Baptiste Daroussin wrote: >>> I know I already told you the following, but I think it is worth sayi= ng it >>> loudly for other people who don't know yet about OPTIONS_DEFINE_${arc= h} >>> >>> regards, >>> Bapt >>> >>> On Mon, Nov 19, 2012 at 04:22:35PM +0000, Wesley Shields wrote: >>>> Author: wxs >>>> Date: Mon Nov 19 16:22:34 2012 >>>> New Revision: 307565 >>>> URL: http://svnweb.freebsd.org/changeset/ports/307565 >>>> >>> ... >>>> WANT_PERL=3D yes >>>> =20 >>>> -OPTIONS=3D PTHREADS "Enable pthreads support" off \ >>>> - IPV6 "Enable IPv6 support" on \ >>>> - ICONV "Enable international character support" on \ >>>> - PERL "Enable perl support" on \ >>>> - OPTIMIZED_ASM "Use assembler optimizations (i386 only)" on >>>> +OPTIONS_DEFINE=3D PTHREADS IPV6 ICONV PERL OPTIMIZED_ASM >>>> +PTHREADS_DESC=3D "Enable pthreads support" >>>> +OPTIMIZED_ASM_DESC=3D "Use assembler optimizations (i386 only)" >>>> +OPTIONS_DEFAULT=3D IPV6 ICONV PERL OPTIMIZED_ASM >>> >>> OPTIONS_DEFINE=3D -PTHREADS IPV6 ICONV PERL >>> OPTIONS_DEFINE_i386=3D OPTIMIZED_ASM >>> OPTIMIZED_ASM_DESC=3D Use assembler optimizations >>> ... >>>> -.include >>>> +.include >>>> =20 >>>> .if ${ARCH} !=3D "i386" >>>> WITHOUT_OPTIMIZED_ASM=3D yes >>>> .endif >>> >>> The above is uneeded as OPTIMIZED_ASM will never get defined with the= _arch >>> syntax above. >> >> Fixed all of these. Thanks for catching it and pointing me to the prop= er >> way to do it! >> >> I do have one question. In r307732 I had to change ${PERL} to just >> 'perl' in the PERL_ARCHNAME!=3D line. This was working prior to the sw= itch >> to the new options so I'm curious if I did something wrong or uncovere= d >> a bug? >> >> -- WXS >=20 > This is because ${PERL} is set by USE_PERL5, which is included after > bsd.port.options.mk and you need it at the moment you parse the Makefil= e because > of: PERL_ARCHNAME!=3D ${PERL} -V:archname 2>/dev/null || true Additionally, running perl(1) here doesn't work in a clean jail, such building with poudriere: =3D=3D=3D=3D>> [03] Starting build of net/silc-irssi-plugin perl: not found "/usr/ports/net/silc-irssi-plugin/../silc-client/Makefile", line 100: warning: "perl -V:archname" returned non-zero status-- Regards, Bryan Drewery bdrewery@freenode/EFNet --------------enigB7E502E5F93026A47CB0CE73 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJQsp1+AAoJEG54KsA8mwz5iK0QALsgUalLLnT2kZ7+CF4u0TWk cAbKH5ykXM4or4xvSZ4WvIaYH43wGBDnjX6jLVnzAFyp3HpvxQAsUWIBF+ArH/sP 4c0KZhGKIf5msgRTl0to5AtdP3yZ4582JZOqa4XYBcFoa7KzhUi0ZFqQjbexlHX5 qK3QPL3c9BIXPiiGUtlnPWXbdDDklwNA7+8vRkEqaW8YuX5LyfrppiA3kG+ZM2aw /o9BSAvJ9DsARIU1dl+c37kYq3zFb4R+fgUVFJCTr0+URC1dM40mX8jTlPYF1ETC 9AO8xDIBc/eQbkwXue1+TySHEEqBVQ/YoYgMiuXNQrZBsVnix7Zz8+DdWERA27vx PSgkUA5u15roAmMAA2IhE6ox/Ddg+kyYmPXZi1y2AaFeVi54PTg27MNzgrBFDPMj R5KaR5Q0j01RuoM0wbolJn/c8aq9kth+/Q0JEw6wFhsnRSVNKM7uD2N95GrEAhL2 IrBcv2Xo2iJMkYvPPqbpOXR5hEbwNCnQe7dFmrvYEgoXA/gSfzv1SfbrovV+9mvo sm7cjl5bkrSO83Cw2uTmpZPu2jTOAgjd1J8vz4onOblVjytKngiMdo2zCTAJIltp WX/Um+ZyXR1CZkFzKjYih/zpfn4AkEFHioDVywiD/t0GC4Cl/Ma5+HsQ5cls/1Yx AT6h1yn1HRqtXy6N5MHQ =WoXw -----END PGP SIGNATURE----- --------------enigB7E502E5F93026A47CB0CE73--