From owner-freebsd-ports Wed Feb 26 18:58:22 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id SAA26207 for ports-outgoing; Wed, 26 Feb 1997 18:58:22 -0800 (PST) Received: from who.cdrom.com (who.cdrom.com [204.216.27.3]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id SAA26195 for ; Wed, 26 Feb 1997 18:58:19 -0800 (PST) Received: from veda.is (ubiq.veda.is [193.4.230.60]) by who.cdrom.com (8.7.5/8.6.11) with ESMTP id SAA15483 for ; Wed, 26 Feb 1997 18:58:17 -0800 (PST) Received: (from adam@localhost) by veda.is (8.8.4/8.7.3) id DAA01353; Thu, 27 Feb 1997 03:10:22 GMT From: Adam David Message-Id: <199702270310.DAA01353@veda.is> Subject: Re: make -k oddities In-Reply-To: <199702262339.PAA03965@vader.cs.berkeley.edu> from Satoshi Asami at "Feb 26, 97 03:39:12 pm" To: asami@vader.cs.berkeley.edu (Satoshi Asami) Date: Thu, 27 Feb 1997 03:10:20 +0000 (GMT) Cc: imp@village.org, freebsd-ports@freebsd.org X-Mailer: ELM [version 2.4ME+ PL31 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-ports@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > * We don't have FETCH_COOKIE, and if we did the dependency would cause > * make -k to skip the build as expected. > > This has nothing to do with cookies, Adam. Look at the "fetch:" > target, and see how it returns 0 if "make -k" doesn't report failure. > Now look at the other targets (with my proposed patch), and see how > the cookies will be created anyway if "make -k" doesn't report > failure. I had a hypothetical bsd.port.mk in mind, creating *_COOKIE at a deeper level. My eyelids were snapping shut after a long day and I missed seeing that the return value of the inner make is just as significant in this context. I withdraw my previous comment as non-applicable. Adam