From owner-svn-ports-all@freebsd.org Sun Mar 22 08:32:40 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4CB9327AB84; Sun, 22 Mar 2020 08:32:40 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48lW3W6hypz4Dw9; Sun, 22 Mar 2020 08:32:39 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 9306CE547; Sun, 22 Mar 2020 08:32:39 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (unknown [IPv6:2a01:678:42:ffff:9d22:c5a1:48a:396b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 54054942E97; Sun, 22 Mar 2020 08:32:38 +0000 (UTC) Date: Sun, 22 Mar 2020 09:32:37 +0100 From: Mathieu Arnold To: Gerald Pfeifer Cc: John Hixson , Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r528808 - head/net/nsq Message-ID: <20200322083237.vaqvidavvdu2jrcj@atuin.in.mat.cc> References: <202003202245.02KMjo5Z005946@repo.freebsd.org> <20200321172227.zn7i4ov6vkvtboii@aching.in.mat.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fnbm4vjahqk7e7xo" Content-Disposition: inline In-Reply-To: X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2020 08:32:40 -0000 --fnbm4vjahqk7e7xo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 21, 2020 at 09:13:48PM +0100, Gerald Pfeifer wrote: > On Sat, 21 Mar 2020, Mathieu Arnold wrote: > >> +PORTREVISION=3D 2 > > Why bump PORTREVISION? >=20 > John, as a bit more color: when a commit solely allows a port to build=20 > that failed to build before, or build where it did not build before (OS= =20 > version, architecture,...) we don't usually bump PORTREVISION. I do not understand what is so hard with understanding why PORTREVISION exists. PORTREVISION exists to tell tools that a package is obsolete and needs to be rebuilt. We bump it when we make changes to the port that whilst the upstream version of the port stays the same, the package needs to be rebuilt because reasons. (Reasons explained in the porter's handbook.) If it was not building before, then there is no obsolete package with the same version, so you do not bump PORTREVISION. --=20 Mathieu Arnold --fnbm4vjahqk7e7xo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl53IqVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkgwcQ//efdXh3xO0sMrZvqfIpk1y6bLcHq9IBmbPrBU/wdAD53BKXOXySeglBx0 p5hqLrZ6s3egFRPkuiSsUo1xYMmVedZ95h9xl4H2I99LICGRQmoccr0ikvLiJl3d CQzUoHcuqFD9y0oJpby8xpH93UIlj6wAXvjucZksdinSYvXlqGw/ShCn5AfP/8GR ENViI/3vpDbnIpEF6+uceLJ6N7FzBkEXxp2PtwXE71vWkBfiz/4KsEiCt2valvbz AyBArTXRrd1lkAdCQVCTrP0hP+/RDd8YSKUp8My421RtM9+AEVrYbq44JwzroTIU IXo5NL7s5MGAxXX0gSwvPV+SRNK4u5O74srXVnvuVU2uymFhrVXN6jphzB6tNkAc b7KyErq6lGy5XGjPUOmSc7E5inB7jLTEcctQLXsSt5j3Gnv3hKNsqg4GxuUuIN8g X5g7kWThQVxJRpDHl8ZBFS81xTCR0tujD3o19SlMLYgehPODK2Fp1K1ux+fhRNXR ruOHk//94rkC6nHATKCBFd8Bzu6vdQkn+dX8UAg/9Po8MXJjMSDFGOkuIkuULcKZ Tx6FKGi7uDcK3U+GJd1vjOqlywe3YLQqGjymsINYyKnSMA5pyxmYSXV9JMqXKlAf AsSZ1R9zK3fXHmVJutZ1mRoGEO+SiL9FLL+v71VSqb7bCiLwdDU= =sFua -----END PGP SIGNATURE----- --fnbm4vjahqk7e7xo--