From owner-freebsd-current@freebsd.org Sun Feb 28 23:25:10 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C626BAB8A49 for ; Sun, 28 Feb 2016 23:25:10 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B14EB1C5 for ; Sun, 28 Feb 2016 23:25:10 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id AF6AAAB8A48; Sun, 28 Feb 2016 23:25:10 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF036AB8A47 for ; Sun, 28 Feb 2016 23:25:10 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 76A2C1C4 for ; Sun, 28 Feb 2016 23:25:10 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::e854:b466:3255:c8fc] (unknown [IPv6:2001:7b8:3a7:0:e854:b466:3255:c8fc]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 46C3B14E47; Mon, 29 Feb 2016 00:25:07 +0100 (CET) Subject: Re: buffer overflow warning in /bin/sh Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Content-Type: multipart/signed; boundary="Apple-Mail=_ED6EEB56-3E4C-400D-B1B9-28AAA243F883"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.6b2 (ebbf3ef) From: Dimitry Andric In-Reply-To: <20160228221659.GA30583@stack.nl> Date: Mon, 29 Feb 2016 00:24:44 +0100 Cc: Howard Su , current@freebsd.org Message-Id: <6FC0C3D8-EF6E-4648-903A-92CB1B49DB1F@FreeBSD.org> References: <0353BD46-1397-4DAC-9115-6D2355E7F42D@FreeBSD.org> <20160228221659.GA30583@stack.nl> To: Jilles Tjoelker X-Mailer: Apple Mail (2.3112) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2016 23:25:10 -0000 --Apple-Mail=_ED6EEB56-3E4C-400D-B1B9-28AAA243F883 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 28 Feb 2016, at 23:16, Jilles Tjoelker wrote: >=20 > On Fri, Feb 26, 2016 at 06:21:20PM +0100, Dimitry Andric wrote: ... >> This frame has 3 object(s): >> [16, 20) 'bqlist' >> [32, 128) 'state_static' <=3D=3D Memory access at offset 32 is = inside this variable >> [160, 170) 'buf' ... >> This may be a false positive though. >=20 > The reported store, which is near the top of the function, is clearly > within bounds. Yes, it's definitely a false positive. I'm still attempting to find out where this goes awry, but it isn't in sh, at least. (After some help from Bryan Drewery I managed to run it through valgrind-devel, and that does not complain about anything...) -Dimitry --Apple-Mail=_ED6EEB56-3E4C-400D-B1B9-28AAA243F883 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.29 iEUEARECAAYFAlbTgdIACgkQsF6jCi4glqPSIwCXTELmES3jxOJ9FQ91HY9JI88q 1wCg3fYygZAH7AKFd4E5KG7QgrqQJLU= =CHmz -----END PGP SIGNATURE----- --Apple-Mail=_ED6EEB56-3E4C-400D-B1B9-28AAA243F883--