Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Mar 2010 10:58:30 GMT
From:      "Dmitry S. Luhtionov" <mitya@cabletv.dp.ua>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/144617: [PATCH] net-mgmt/docsis: Fix build on systems where GCC stack protection was enabled for userland
Message-ID:  <201003101058.o2AAwUaZ021129@www.freebsd.org>
Resent-Message-ID: <201003101100.o2AB0GqK014460@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         144617
>Category:       ports
>Synopsis:       [PATCH] net-mgmt/docsis: Fix build on systems where GCC stack protection was enabled for userland
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 10 11:00:16 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Dmitry S. Luhtionov
>Release:        8.0-STABLE i386
>Organization:
>Environment:
FreeBSD m18.cabletv.dp.ua 8.0-STABLE FreeBSD 8.0-STABLE #0: Mon Mar  1 15:40:45 EET 2010     mitya@m18.cabletv.dp.ua:/usr/src/sys/i386/compile/m18  i386
>Description:
- Fix build on systems (FreeBSD 8+) where GCC stack protection (aka
Propolice) was enabled for userland on src/share/mk/bsd.sys.mk
(SVN rev 180012 on 2008-06-25 21:33:28Z by ru)
- For OSVERSION >= 800040, add -fstack-protector to LDFLAGS
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile	2009-08-23 17:33:57.000000000 +0300
+++ Makefile	2010-03-10 12:52:49.000000000 +0200
@@ -27,4 +27,13 @@
 	@${REINPLACE_CMD} -e 's|^htmldocdir =.*|htmldocdir = ${DOCSDIR}|' ${WRKSRC}/doc/Makefile.in
 	@${REINPLACE_CMD} -e 's|^examplesdir =.*|examplesdir = ${EXAMPLESDIR}|' ${WRKSRC}/examples/Makefile.in
 
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+# Around the time GCC stack protection (aka Propolice) for userland
+# was enabled on src/share/mk/bsd.sys.mk
+# SVN rev 180012 on 2008-06-25 21:33:28Z by ru
+.if ${OSVERSION} >= 800040
+LDFLAGS+=       -fstack-protector
+.endif
+
+.include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003101058.o2AAwUaZ021129>