From owner-svn-src-all@FreeBSD.ORG  Wed Dec 17 23:08:34 2008
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E311E106564A;
	Wed, 17 Dec 2008 23:08:34 +0000 (UTC)
	(envelope-from trasz@FreeBSD.org)
Received: from pin.if.uz.zgora.pl (pin.if.uz.zgora.pl [212.109.128.251])
	by mx1.freebsd.org (Postfix) with ESMTP id 9A07A8FC16;
	Wed, 17 Dec 2008 23:08:34 +0000 (UTC)
	(envelope-from trasz@FreeBSD.org)
Received: by pin.if.uz.zgora.pl (Postfix, from userid 1001)
	id 0909039BC9; Wed, 17 Dec 2008 23:57:06 +0100 (CET)
Date: Wed, 17 Dec 2008 23:57:05 +0100
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
To: Ulrich Spoerlein <uspoerlein@gmail.com>
Message-ID: <20081217225705.GA16689@pin.if.uz.zgora.pl>
References: <200812162113.mBGLDCkB047820@svn.freebsd.org>
	<20081217175758.GD8716@roadrunner.spoerlein.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
In-Reply-To: <20081217175758.GD8716@roadrunner.spoerlein.net>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r186194 - in head: share/man/man9 sys/fs/hpfs
	sys/fs/msdosfs sys/fs/ntfs sys/fs/nwfs sys/fs/smbfs
	sys/gnu/fs/ext2fs sys/gnu/fs/reiserfs sys/gnu/fs/xfs/FreeBSD
	sys/ufs/ufs
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Dec 2008 23:08:35 -0000

On 1217T1857, Ulrich Spoerlein wrote:
> > Author: trasz
> > Date: Tue Dec 16 21:13:11 2008
> > New Revision: 186194
> > URL: http://svn.freebsd.org/changeset/base/186194
> > 
> > Log:
> >   According to phk@, VOP_STRATEGY should never, _ever_, return
> >   anything other than 0.  Make it so.  This fixes
> >   "panic: VOP_STRATEGY failed bp=0xc320dd90 vp=0xc3b9f648",
> >   encountered when writing to an orphaned filesystem.  Reason
> >   for the panic was the following assert:
> >   KASSERT(i == 0, ("VOP_STRATEGY failed bp=%p vp=%p", bp, bp->b_vp));
> >   at vfs_bio:bufstrategy().
> 
> Is such a change also needed/recommended for the FUSE port?

It seems fusefs-kmod already does the right thing by always
returning 0.

-- 
If you cut off my head, what would I say?  Me and my head, or me and my body?