Date: Wed, 13 Apr 2016 18:12:42 +1000 From: Peter Jeremy <peter@rulingia.com> To: Steve Wills <swills@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297902 - head Message-ID: <20160413081242.GA10478@server.rulingia.com> In-Reply-To: <201604130147.u3D1l5F0032629@repo.freebsd.org> References: <201604130147.u3D1l5F0032629@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2016-Apr-13 01:47:05 +0000, Steve Wills <swills@FreeBSD.org> wrote: >+.if !defined(SVN) || empty(SVN) >+. for _P in /usr/bin /usr/local/bin >+. for _S in svn svnlite >+. if exists(${_P}/${_S}) >+SVN=3D ${_P}/${_S} >+. endif >+. endfor >+. endfor >+.endif What is the preferred choice here? The given order prefers ports over base (which makes sense) but then prefers svnlite over svn. I would expect either the opposite directory order in _P (prefer svnlite in base) or the opposite command order in _S (prefer svn in ports). In normal use, this will wind up with either /usr/local/bin/svn or /usr/bin/svnlite (in that order) but a non-standard configuration could result in different results. --=20 Peter Jeremy --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJXDf96XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFRUIyOTg2QzMwNjcxRTc0RTY1QzIyN0Ux NkE1OTdBMEU0QTIwQjM0AAoJEBall6Dkogs0D5MP/2pP9sp3UE9jda6VN4+gTvHU DXryxkVeWxxbwsclxEtpREBqgFf4lWzgprzuVcM2oQbsHZdkW+TchTts+nQFdl6/ 65WjwCla+AdegwMZ69+KXW942t0tSLf3d1PTUQB8V/ysOqGbZcDZb8e9YwMUShBy DzKDC+90mVJGoN7q2DxIxXYrjhb+ncyVaT4peDRtNSc43h5YGimCKZKLTHYyNnKs w/Ew1JsLZjJzThyae5djns8uq7y8xxi86+Ku7/FDL+W4MvWjXxZni700sOOyBbSu 0BFRJJP1IwNXw6olBWGoTi4PfM/gbCj5T9H19xY3AcaugMT/wdDwkW9U2lcBsAtt b7h1d0H6snjI9FuWDSq+Cd+TEkxobhKjrm50YRN3JhZtP2ea3PWOzk9VyD1AdTWB UaX0hLRadGGDqefrkfQJ3E0Oa7Y+bWGQHUUD/Dv+4T/PbKje0mgkOuS/SJ4jV4HE A4Refa8nDb6EXtJ7yp4y7jbWhkQ5xBr9zI6c+O6uwq+3xXya92BrpHKkpG8xqGX5 r370DGIve5PUeIIRQHo5zGZiRFP1dgipMlZy/FHhDYHjhZs+8ZcDi9/LfgQGMZiG LQcA1wMt64rpyEdkFaWEeAlDTQW2+JnEwT6Vep1hlT2AN2Ab0itfp7NaVFG6cb9c WMSkxvMk9fP/agnzgIUi =bLFU -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160413081242.GA10478>