From owner-svn-src-all@FreeBSD.ORG Tue Jan 13 15:55:16 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D318D435; Tue, 13 Jan 2015 15:55:15 +0000 (UTC) Received: from mail-ie0-x230.google.com (mail-ie0-x230.google.com [IPv6:2607:f8b0:4001:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F4EB175; Tue, 13 Jan 2015 15:55:15 +0000 (UTC) Received: by mail-ie0-f176.google.com with SMTP id tr6so3482074ieb.7; Tue, 13 Jan 2015 07:55:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=mZjPfg49ANjWl3cxw/f2b9aD7uRAgIYwoCVvJZdUXlo=; b=JkxTpglg67KNqTPpbb5PJ3THN8rR6nQx+io5eEsm7PYHiUqV9KJ+SpWVkiO+hWIlPS IomSrHIJYucW3yVyVFYnj/ItgUafFxxs2t6Oz8wM/aQfYx9Tv+UOUS4DuPOkf+SS38bd 9WETRXI1Y0n8k9X9om8ZoDk0zCFqlyauDf0OflOt1qpzHYdQz0CFP0xNNa4sLm/2mUNu WcLDie1yqHPd27IhkIyZglqTrmyefOA60njC5nRn51lx3Og1sk2ajJYBofKFSYVLH2pF TM3YDzW/sbr78+L8A7f66LjDj3+lAvCY6n48059jmGdmcojLtSNOcZt0rL/Lo0ZUppgT hJEg== X-Received: by 10.42.103.7 with SMTP id k7mr29294727ico.33.1421164514661; Tue, 13 Jan 2015 07:55:14 -0800 (PST) MIME-Version: 1.0 Sender: mr.kodiak@gmail.com Received: by 10.64.71.228 with HTTP; Tue, 13 Jan 2015 07:54:44 -0800 (PST) In-Reply-To: <7A28D39E-7C21-4081-83E0-656F8082D525@fh-muenster.de> References: <201410100609.s9A690NU067686@svn.freebsd.org> <54AC6F4E.1000707@FreeBSD.org> <6173473.uE5Sr5nj0c@ralph.baldwin.cx> <88ADFC71-FD44-4012-9814-1771D31646FF@FreeBSD.org> <7A28D39E-7C21-4081-83E0-656F8082D525@fh-muenster.de> From: Bryan Venteicher Date: Tue, 13 Jan 2015 09:54:44 -0600 X-Google-Sender-Auth: OU3AoN3pAAxE6cfuNEqChxmjqbE Message-ID: Subject: Re: svn commit: r272886 - in head/sys: netinet netinet6 To: Michael Tuexen Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "src-committers@freebsd.org" , John Nielsen , Bryan Venteicher , "svn-src-all@freebsd.org" , Bryan Drewery , John Baldwin , "Bjoern A. Zeeb" , "svn-src-head@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jan 2015 15:55:16 -0000 On Mon, Jan 12, 2015 at 5:20 PM, Michael Tuexen wrote: > > > On 12 Jan 2015, at 18:42, Bjoern A. Zeeb wrote: > > > > > >> On 12 Jan 2015, at 15:51 , John Baldwin wrote: > >> > >> On Tuesday, January 06, 2015 07:07:11 PM Bryan Venteicher wrote: > >>> On Tue, Jan 6, 2015 at 5:27 PM, Bryan Drewery > wrote: > >>>> On 1/6/2015 4:00 PM, Bryan Venteicher wrote: > >>>>> On Tue, Jan 6, 2015 at 2:52 PM, John Nielsen >>>>> > >>>>> > wrote: > >>>>> Bryan- > >>>>> > >>>>> On Oct 10, 2014, at 12:09 AM, Bryan Venteicher >>>>> > >>>>> > wrote: > >>>>>> Author: bryanv > >>>>>> Date: Fri Oct 10 06:08:59 2014 > >>>>>> New Revision: 272886 > >>>>>> URL: https://svnweb.freebsd.org/changeset/base/272886 > >>>>>> > >>>>>> Log: > >>>>>> Add context pointer and source address to the UDP tunnel callback > >>>>>> > >>>>>> These are needed for the forthcoming vxlan implementation. The > >>>> > >>>> context > >>>> > >>>>>> pointer means we do not have to use a spare pointer field in the > >>>> > >>>> inpcb, > >>>> > >>>>>> and the source address is required to populate vxlan's forwarding > >>>> > >>>> table. > >>>> > >>>>>> While I highly doubt there is an out of tree consumer of the UDP > >>>>>> tunneling callback, this change may be a difficult to eventually > >>>> > >>>> MFC. > >>>> > >>>>> I noticed this comment while doing an MFC of vxlan to my local > tree. > >>>>> Do you think an MFC to 10-STABLE of this change (and vxlan > >>>>> generally) will be feasible? Is there precedent for ABI changes > like > >>>>> this being sanctioned? Could symbol versioning help? > >>>>> > >>>>> I'd like to get some consensus on whether this commit is OK to MFC. > With > >>>>> this commit, vxlan should be an easy to MFC. > >>>> > >>>> Breaking ABI will potentially hurt packages. FreeBSD builds packages > for > >>>> the oldest supported release on a branch. If you break ABI in 10.2 > while > >>>> we are building packages for 10.1 then any packages using these > >>>> interfaces may not work right or result in panics packages with kmod= s. > >>>> Please consider that. > >>> > >>> The only user visible change of this commit would be the addition of = a > >>> field at the end of 'struct udpcb'. I don't think that is a problem, = at > >>> least a similar change didn't prevent the MFC of UDP Lite. > >>> > >>> The kernel part of this changes the UDP tunneling functions which I > guess > >>> there could be a 3rd party module out there, but I very highly doubt > that, > >>> based on how un-useful the previous interface was. > >> > >> Userland should not be impacted by this at all. (Nothing in userland > cares > >> about udpcb's internals.) I think there was only ever one consumer fo= r > the > >> existing UDP tunneling code (bz@ knows what it is). I'm not sure > where it > >> lives. > > > > If you are talking about u_tun_func then it came from SCTP over UDP > tunneling. tuexen and rrs are your friends. > rrs implemented it to support SCTP over UDP over IPv[46]. To be more > precisely, to > receive such packets. > > So I am just being overly cautious and this change is fine to MFC? Best regards > Michael > > > > I was wondering if it could be used similarly for IPsec UDPencap but I > think that went nowhere back then. > > > > =E2=80=94 > > Bjoern A. Zeeb Charles Haddon Spurgeon= : > > "Friendship is one of the sweetest joys of life. Many might have faile= d > > beneath the bitterness of their trial had they not found a friend." > > > > > > > >