From owner-svn-src-all@FreeBSD.ORG  Mon Dec 26 13:19:57 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 071CD1065672;
	Mon, 26 Dec 2011 13:19:57 +0000 (UTC)
	(envelope-from chmeeedalf@gmail.com)
Received: from mail-tul01m020-f182.google.com (mail-tul01m020-f182.google.com
	[209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 890238FC23;
	Mon, 26 Dec 2011 13:19:56 +0000 (UTC)
Received: by obbwd18 with SMTP id wd18so9893802obb.13
	for <multiple recipients>; Mon, 26 Dec 2011 05:19:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=cc:message-id:from:to:in-reply-to:content-type
	:content-transfer-encoding:mime-version:subject:date:references
	:x-mailer; bh=uljutgHNRvMaFf49yv5mUdIP9MgTrFlEr9cZX73pt+U=;
	b=jh4qp8ur6lg8vgRlPjK1EjU0H5CxwyVSp/7SQdVqpvk5DZ/9ze/+2gOTXO/vEleZ/4
	w6hcqG8CwJ5Hhh2gu70oPM5eqSPOZZAPbq8ekMVDHCjEpa4l0UIh/Gak51iEe6uDt1uv
	Ab6b+Iqx6+KhOUypbjQVAQnh8amOIGeMDVNgE=
Received: by 10.50.51.199 with SMTP id m7mr26463999igo.23.1324903899872;
	Mon, 26 Dec 2011 04:51:39 -0800 (PST)
Received: from triad.knownspace
	(216-15-41-8.c3-0.gth-ubr1.lnh-gth.md.cable.rcn.com. [216.15.41.8])
	by mx.google.com with ESMTPS id gf6sm59851129igb.1.2011.12.26.04.51.38
	(version=TLSv1/SSLv3 cipher=OTHER);
	Mon, 26 Dec 2011 04:51:39 -0800 (PST)
Message-Id: <0AA7AB29-F489-4C8E-BA2A-85DC6788FFC6@gmail.com>
From: Justin Hibbits <chmeeedalf@gmail.com>
To: Doug Barton <dougb@FreeBSD.org>
In-Reply-To: <4EF812F4.9010902@FreeBSD.org>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Date: Mon, 26 Dec 2011 07:50:16 -0500
References: <201112251429.pBPETawV062695@svn.freebsd.org>
	<4EF812F4.9010902@FreeBSD.org>
X-Mailer: Apple Mail (2.936)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	"Bjoern A. Zeeb" <bz@FreeBSD.org>, src-committers@freebsd.org
Subject: Re: svn commit: r228874 - head/sys/dev/hwpmc
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Dec 2011 13:19:57 -0000

On Dec 26, 2011, at 1:23 AM, Doug Barton wrote:

> On 12/25/2011 06:29, Bjoern A. Zeeb wrote:
>> Author: bz
>> Date: Sun Dec 25 14:29:36 2011
>> New Revision: 228874
>> URL: http://svn.freebsd.org/changeset/base/228874
>>
>> Log:
>>  Quite the tinderbox for the holidays.  Remove the assert[1].
>
> Shouldn't "Why it's Ok to remove the assert" be part of this commit  
> log?

When I suggested the removal, I didn't see it as necessary, and was  
just looking to quiet the build for now while I look closer.  Right  
now, that code is never called, as it's only used when configured for  
sampling, and that code was originally just a copy from the hwpmc_amd  
driver.  I will be finishing the sampling code in the new year.

- Justin