From owner-svn-src-head@freebsd.org Fri May 4 19:21:06 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7AED3FB5AB3; Fri, 4 May 2018 19:21:06 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C996779298; Fri, 4 May 2018 19:21:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 9A5481F015; Fri, 4 May 2018 19:21:05 +0000 (UTC) (envelope-from jhb@freebsd.org) From: John Baldwin To: Peter Grehan Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333230 - head/sys/dev/pci Date: Fri, 04 May 2018 12:14:27 -0700 Message-ID: <2195289.fHIjn0Ke9p@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <201805032251.w43MpihV067395@repo.freebsd.org> References: <201805032251.w43MpihV067395@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 19:21:06 -0000 On Thursday, May 03, 2018 10:51:44 PM Peter Grehan wrote: > Author: grehan > Date: Thu May 3 22:51:44 2018 > New Revision: 333230 > URL: https://svnweb.freebsd.org/changeset/base/333230 > > Log: > Allow PCI VGA devices to be detached. > > GPUs often have a VGA PCI class code and are probed/attached > by the VGA driver. Allow them to be detached so they can > be presented as passthru devices to VM guests. > > Submitted by: mmacy > Reviewed by: jhb, imp, rgrimes > MFC after: 3 weeks > Differential Revision: https://reviews.freebsd.org/D15269 I forgout about this earlier, sorry. We probably should also explicitly release any resources cached in sc->vga_bios and sc->vga_bars. In theory they should be clear by the time bus_generic_detach finishes, but perhaps we should walk the resources and whine if they aren't released and then release them. -- John Baldwin