Date: Sun, 11 Apr 2004 20:10:19 -0700 (PDT) From: Sean McGovern <sean@sfarc.net> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/64964: audio/faad broken on amd64 Message-ID: <200404120310.i3C3AJ8e059187@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/64964; it has been noted by GNATS. From: Sean McGovern <sean@sfarc.net> To: Tim Robbins <tjr@freebsd.org> Cc: pav@freebsd.org, bug-followup@freebsd.org Subject: Re: ports/64964: audio/faad broken on amd64 Date: Sun, 11 Apr 2004 23:09:37 -0400 I have no access to AMD64 equipment to verify this On 11-Apr-04, at 8:15, Tim Robbins wrote: > Here is a patch that makes audio/faad work on amd64; it's essentially > a backport of this patch from faad CVS: > http://cvs.sourceforge.net/viewcvs.py/faac/faad2/libfaad/structs.h? > r1=1.36&r2=1.37 > > Add this file as ports/audio/faad/files/patch-structs_h: > > --- libfaad/structs.h.orig Thu Nov 13 07:47:59 2003 > +++ libfaad/structs.h Sun Apr 11 22:01:09 2004 > @@ -297,57 +297,57 @@ > typedef struct mp4AudioSpecificConfig > { > /* Audio Specific Info */ > - uint8_t objectTypeIndex; > - uint8_t samplingFrequencyIndex; > - uint32_t samplingFrequency; > - uint8_t channelsConfiguration; > + unsigned char objectTypeIndex; > + unsigned char samplingFrequencyIndex; > + unsigned long samplingFrequency; > + unsigned char channelsConfiguration; > > /* GA Specific Info */ > - uint8_t frameLengthFlag; > - uint8_t dependsOnCoreCoder; > - uint16_t coreCoderDelay; > - uint8_t extensionFlag; > - uint8_t aacSectionDataResilienceFlag; > - uint8_t aacScalefactorDataResilienceFlag; > - uint8_t aacSpectralDataResilienceFlag; > - uint8_t epConfig; > + unsigned char frameLengthFlag; > + unsigned char dependsOnCoreCoder; > + unsigned short coreCoderDelay; > + unsigned char extensionFlag; > + unsigned char aacSectionDataResilienceFlag; > + unsigned char aacScalefactorDataResilienceFlag; > + unsigned char aacSpectralDataResilienceFlag; > + unsigned char epConfig; > > - int8_t sbr_present_flag; > - int8_t forceUpSampling; > + char sbr_present_flag; > + char forceUpSampling; > } mp4AudioSpecificConfig; > > typedef struct faacDecConfiguration > { > - uint8_t defObjectType; > - uint32_t defSampleRate; > - uint8_t outputFormat; > - uint8_t downMatrix; > - uint8_t useOldADTSFormat; > + unsigned char defObjectType; > + unsigned long defSampleRate; > + unsigned char outputFormat; > + unsigned char downMatrix; > + unsigned char useOldADTSFormat; > } faacDecConfiguration, *faacDecConfigurationPtr; > > typedef struct faacDecFrameInfo > { > - uint32_t bytesconsumed; > - uint32_t samples; > - uint8_t channels; > - uint8_t error; > - uint32_t samplerate; > + unsigned long bytesconsumed; > + unsigned long samples; > + unsigned char channels; > + unsigned char error; > + unsigned long samplerate; > > /* SBR: 0: off, 1: on; normal, 2: on; downsampled */ > - uint8_t sbr; > + unsigned char sbr; > > /* MPEG-4 ObjectType */ > - uint8_t object_type; > + unsigned char object_type; > > /* AAC header type; MP4 will be signalled as RAW also */ > - uint8_t header_type; > + unsigned char header_type; > > /* multichannel configuration */ > - uint8_t num_front_channels; > - uint8_t num_side_channels; > - uint8_t num_back_channels; > - uint8_t num_lfe_channels; > - uint8_t channel_position[MAX_CHANNELS]; > + unsigned char num_front_channels; > + unsigned char num_side_channels; > + unsigned char num_back_channels; > + unsigned char num_lfe_channels; > + unsigned char channel_position[MAX_CHANNELS]; > } faacDecFrameInfo; > > typedef struct > > ------------------------------------------------------------------------ ----------- Sean McGovern | "The day my dream became endless mailto:sean@sfarc.net | ...I wonder when it was?" - Kanon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404120310.i3C3AJ8e059187>