From owner-freebsd-amd64@FreeBSD.ORG  Sat Jan 31 12:54:00 2004
Return-Path: <owner-freebsd-amd64@FreeBSD.ORG>
Delivered-To: freebsd-amd64@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 82E2916A4CE
	for <freebsd-amd64@freebsd.org>; Sat, 31 Jan 2004 12:54:00 -0800 (PST)
Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0038E43D41
	for <freebsd-amd64@freebsd.org>; Sat, 31 Jan 2004 12:53:58 -0800 (PST)
	(envelope-from jmg@hydrogen.funkthat.com)
Received: (qmail 3591 invoked from network); 31 Jan 2004 20:53:58 -0000
Received: from dsl017-045-168.spk4.dsl.speakeasy.net (HELO
	hydrogen.funkthat.com) ([69.17.45.168])
	(envelope-sender <jmg@hydrogen.funkthat.com>)
	by mail3.speakeasy.net (qmail-ldap-1.03) with SMTP
	for <xcas@cox.net>; 31 Jan 2004 20:53:58 -0000
Received: from hydrogen.funkthat.com (pkdapa@localhost.funkthat.com
	[127.0.0.1])i0VKrvj2071536;	Sat, 31 Jan 2004 12:53:57 -0800 (PST)
	(envelope-from jmg@hydrogen.funkthat.com)
Received: (from jmg@localhost)
	by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i0VKrt9G071535;
	Sat, 31 Jan 2004 12:53:55 -0800 (PST)
Date: Sat, 31 Jan 2004 12:53:55 -0800
From: John-Mark Gurney <gurney_j@efn.org>
To: "Greg J." <xcas@cox.net>
Message-ID: <20040131205355.GY74366@funkthat.com>
Mail-Followup-To: "Greg J." <xcas@cox.net>,
	Adriaan de Groot <adridg@cs.kun.nl>, freebsd-amd64@freebsd.org
References: <200401311932.37140.adridg@cs.kun.nl> <401C02A9.5030506@cox.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <401C02A9.5030506@cox.net>
User-Agent: Mutt/1.4.1i
X-Operating-System: FreeBSD 4.2-RELEASE i386
X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31  96 7A 22 B3 D8 56 36 F4
X-Files: The truth is out there
X-URL: http://resnet.uoregon.edu/~gurney_j/
X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html
cc: Adriaan de Groot <adridg@cs.kun.nl>
cc: freebsd-amd64@freebsd.org
Subject: Re: msdosfs patch
X-BeenThere: freebsd-amd64@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: John-Mark Gurney <gurney_j@efn.org>
List-Id: Porting FreeBSD to the AMD64 platform <freebsd-amd64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-amd64>
List-Post: <mailto:freebsd-amd64@freebsd.org>
List-Help: <mailto:freebsd-amd64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 31 Jan 2004 20:54:00 -0000

Greg J. wrote this message on Sat, Jan 31, 2004 at 12:31 -0700:
> >Since Tim didn't mail his patch to the amd64 list, perhaps you could 
> >re-post it there?
> oops.. I thought Tim's patch went to the freebsd-amd64 list as well.. 
> sorry. It's attached to this email. :)

looks good, though was this (mis)spelling of size_t intentional?

[...]
>  static u_int16_t unix2doschr(const u_char **, size_t *, struct msdosfsmount *);
[...]
> -	int i, j, l;
> +	ssize_t i, j;
> +	int l;
>  	int conv = 1;
>  	const u_char *cp, *dp, *dp1;
>  	u_char gentext[6], *wcp;
> @@ -531,7 +532,7 @@
>  	 * Filenames with some characters are not allowed!
>  	 */
>  	for (cp = un, i = unlen; i > 0;)
> -		if (unix2doschr(&cp, (size_t *)&i, pmp) == 0)
> +		if (unix2doschr(&cp, &i, pmp) == 0)
>  			return 0;
>  
>  	/*

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."