Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 4 Feb 2016 09:06:03 -0800
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        Bryan Drewery <bdrewery@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r295226 - head/lib/libmemstat
Message-ID:  <20160204170603.GF65294@FreeBSD.org>
In-Reply-To: <56B29E36.8000900@FreeBSD.org>
References:  <201602040023.u140NL0i052392@repo.freebsd.org> <56B29E36.8000900@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 03, 2016 at 04:41:26PM -0800, Bryan Drewery wrote:
B> On 2/3/2016 4:23 PM, Gleb Smirnoff wrote:
B> > Author: glebius
B> > Date: Thu Feb  4 00:23:21 2016
B> > New Revision: 295226
B> > URL: https://svnweb.freebsd.org/changeset/base/295226
B> > 
B> > Log:
B> >   Fix build.
B> > 
B> > Modified:
B> >   head/lib/libmemstat/memstat_uma.c
B> > 
B> > Modified: head/lib/libmemstat/memstat_uma.c
B> > ==============================================================================
B> > --- head/lib/libmemstat/memstat_uma.c	Wed Feb  3 23:41:58 2016	(r295225)
B> > +++ head/lib/libmemstat/memstat_uma.c	Thu Feb  4 00:23:21 2016	(r295226)
B> > @@ -29,6 +29,7 @@
B> >  #include <sys/param.h>
B> >  #include <sys/cpuset.h>
B> >  #include <sys/sysctl.h>
B> > +#include <sys/_task.h>
B> >  
B> >  #include <vm/vm.h>
B> >  #include <vm/vm_page.h>
B> > 
B> 
B> Shouldn't uma_int.h forward declare or include _task.h for struct task?

Forward declaration won't work, since structure is included, not pointed at.
I'm reluctant with adding includes into includes.

-- 
Totus tuus, Glebius.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160204170603.GF65294>