From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Nov 18 09:20:31 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9804816A4CE
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu, 18 Nov 2004 09:20:31 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8312943D5F
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu, 18 Nov 2004 09:20:31 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	iAI9KViJ089905	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Thu, 18 Nov 2004 09:20:31 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iAI9KVR4089904;
	Thu, 18 Nov 2004 09:20:31 GMT
	(envelope-from gnats)
Date: Thu, 18 Nov 2004 09:20:31 GMT
Message-Id: <200411180920.iAI9KVR4089904@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: "Volker Stolz" <vs@freebsd.org>
Subject: Re: ports/74033: New port: devel/log4cplus C++ logging API, similar
	to log4j
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Volker Stolz <vs@freebsd.org>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Nov 2004 09:20:31 -0000

The following reply was made to PR ports/74033; it has been noted by GNATS.

From: "Volker Stolz" <vs@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, petri.totterman@hmv.fi
Cc:  
Subject: Re: ports/74033: New port: devel/log4cplus C++ logging API, similar to log4j
Date: Thu, 18 Nov 2004 10:12:33 +0100

 - The correct way for setting pthread-related flags is:
 CONFIGURE_ENV+=         CFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}" \
                          LDFLAGS="${LDFLAGS} ${PTHREAD_LIBS}"
 - You do not install any documentation (must be doxygen'ed?)
 - Especially, please check if you're violating the Apache Software  
 License, sec.2 when generating the binary package!
 - You must use Tabs, not spaces in the Makefile
 - portlint emmitted a warning for pkg-descr
 - It's probably overkill to list email-addresses in pkg-descr
 - Configuring yields:
 ===>  Configuring for log4cplus-1.0.2
 configure: WARNING: you should use --build, --host, --target
 checking for a BSD-compatible install... /usr/bin/install -c -o root -g  
 wheel
 checking whether build environment is sane... yes
 /usr/home/stolz/log4cplus/work/log4cplus-1.0.2/missing: Unknown `--run'  
 option
 Try `/usr/home/stolz/log4cplus/work/log4cplus-1.0.2/missing --help' for  
 more information
 configure: WARNING: `missing' script is too old or missing
 
 Is this a problem?
 - The included libtool-version is 1.5. Although I can't spot any important  
 differences in the build, you might consider setting LIBTOOL_VER to 15  
 instead.
 - GNU Make is not required
 - GNU_CONFIGURE is redundant in the presence of USE_LIBTOOL_VER.
 
 Please review these suggestion. Do not yet submit an updated PR or patch!
 
 Cheers,
    Volker