Date: Wed, 05 Mar 2014 19:05:01 -0500 From: George Mitchell <george+freebsd@m5p.com> To: =?ISO-8859-1?Q?Ren=E9_Ladan?= <r.c.ladan@gmail.com> Cc: freebsd ports <freebsd-ports@freebsd.org> Subject: Re: Adventures in ports, chapter 346785 Message-ID: <5317BBAD.9070107@m5p.com> In-Reply-To: <53170F8B.8080303@gmail.com> References: <5315B8FF.5020907@m5p.com> <CADL2u4jnNqc_2wcz9wfR1GtF2pTEBS=1AjoLn1-iJkLwKsxjLQ@mail.gmail.com> <531673AB.7000807@m5p.com> <5316E0A1.2020406@gmail.com> <53170768.1060504@m5p.com> <53170F8B.8080303@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/05/14 06:50, René Ladan wrote: > On 03/05/2014 12:15, George Mitchell wrote: >> On 03/05/14 03:30, René Ladan wrote: >>> On 03/05/2014 01:45, George Mitchell wrote: >>>> On 03/04/14 13:28, René Ladan wrote: >>>>> 2014-03-04 12:29 GMT+01:00 George Mitchell <george+freebsd@m5p.com >>>>> <mailto:george+freebsd@m5p.com>>: >>>>> >>>>> Couldn't compile chromium without attached patch on FreeBSD 8.4. >>>>> >>>>> >>>>> I committed a slightly different version of your patch in r347055, can >>>>> you retry? >>>>> >>>>> René >>>>> >>>> Thanks for your help, but this doesn't seem to fix the compile errors >>>> in content/browser/browser_shutdown_profile_dumper.cc, >>>> testing/perf/perf_test.cc, or ui/gfx/codec/jpeg_codec.cc that were >>>> caused by the absence or misordering of stdio.h. -- George >>>> >>> Hmm, I did add the patch for >>> content/browser/browser_shutdown_profile_dumper.cc as a conditional >>> patch when using GCC (i.e. in files/extra-patch-gcc). >> >> You are right, I didn't get the FILE error in that file. Sorry for >> typing my reply too quickly. >> > No problem. Does it work now? > >>> I indeed forgot to add the other two patches which I added to >>> files/extra-patch-gcc too (having to place stdio.h before <thisfile>.h >>> looks fishy, but that's another story). >>> >>>> From what I see on my virtual 8.4 box, chromium should choose GCC 4.7+ >>> as compiler (and clang on 10.0). >>> >>> To be really sure, what is the output of 'make -V CHOSEN_COMPILER_TYPE' >>> on your box? >>> >>> René >>> >> >> sullivan.m5p.com.1) uname -a >> FreeBSD sullivan.m5p.com 8.4-STABLE FreeBSD 8.4-STABLE #0 r254883: Sun >> Aug 25 15:52:19 EDT 2013 >> george@sullivan.m5p.com:/usr/obj/usr/src/sys/M5P amd64 >> sullivan.m5p.com.2) make -V CHOSEN_COMPILER_TYPE >> > Uhm, nothing ... I should have said to run this in > /usr/ports/www/chromium ... [...] In /usr/ports/www/chromium, it says "gcc". I have gcc46 and gcc47 installed from ports. -- George
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5317BBAD.9070107>