From owner-cvs-ports@FreeBSD.ORG Thu Feb 19 03:56:43 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9FD9A16A4CE; Thu, 19 Feb 2004 03:56:43 -0800 (PST) Received: from mtaw4.prodigy.net (mtaw4.prodigy.net [64.164.98.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7BE7743D1D; Thu, 19 Feb 2004 03:56:43 -0800 (PST) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (3130103f5713796a13f37dedc655b97c@adsl-63-207-60-37.dsl.lsan03.pacbell.net [63.207.60.37]) by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i1JBufwK010361; Thu, 19 Feb 2004 03:56:41 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id B83BE66CAF; Thu, 19 Feb 2004 03:56:41 -0800 (PST) Date: Thu, 19 Feb 2004 03:56:41 -0800 From: Kris Kennaway To: Maxim Sobolev Message-ID: <20040219115641.GA11791@xor.obsecurity.org> References: <200402191122.i1JBMdHd026435@repoman.freebsd.org> <20040219112932.GA11187@xor.obsecurity.org> <4034A2C4.7030501@portaone.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: <4034A2C4.7030501@portaone.com> User-Agent: Mutt/1.4.1i cc: Maxim Sobolev cc: ports-committers@FreeBSD.ORG cc: cvs-ports@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Kris Kennaway Subject: Re: cvs commit: ports/net/asterisk Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2004 11:56:43 -0000 --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 19, 2004 at 01:49:24PM +0200, Maxim Sobolev wrote: > Kris Kennaway wrote: >=20 > >On Thu, Feb 19, 2004 at 03:22:39AM -0800, Maxim Sobolev wrote: > > > >>sobomax 2004/02/19 03:22:39 PST > >> > >> FreeBSD ports repository > >> > >> Modified files: > >> net/asterisk Makefile=20 > >> Log: > >> Replace '${WRKDIRPREFIX}${PORTSDIR}/' with '${WRKDIR}/../../../' when > >> reffering other ports, since the former for some reason doesn't work > >> in bento environment (it works here just fine even with WRKDIRPREFIX > >> set). > >>=20 > >> BTW, this is good evidence which shows that breakage on bento isn't > >> sufficient to mark port as BROKEN. > > > > > >It exposed your incorrect assumption and made you fix it, didn't it? > >;-) > > > >You were bitten by the fact that bento (deliberately) builds ports in > >/a/ports, with /usr/ports a symlink to this directory. In other > >words, in legitimate environments, ${PORTSDIR} may not be equal to > >${.CURDIR} even though both reference the same directory. >=20 > Or equially likely it exposes a bug in bento's setup, where ${PORTSDIR}= =20 > should be set to /a/ports not to /usr/ports. ;) No, as I said, this is a supported configuration. Moreover, I'm sure it's common for people to move their ports collection from /usr/ports to some other location and replace it with a symlink (in fact I've done that myself), and this works for all 10364 ports except yours, prior to this commit. Thanks for (presumably) fixing it. Kris --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFANKR5Wry0BWjoQKURAo3JAKDP1xCz/Sfa+dGdooYLZGkzJwCShACgrVtf kaAAsWrURDDbNP5Qou61lHk= =q3Nq -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62--