Date: Tue, 7 Mar 2017 22:02:44 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r435576 - head/devel/pkgconf Message-ID: <e2a17a43-d9f9-dbc7-a73c-5317440b4357@FreeBSD.org> In-Reply-To: <201703070103.v2713JtB059883@repo.freebsd.org> References: <201703070103.v2713JtB059883@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q4V4G7wK7t81vhw9uV55PvMxuGpf0ojE1 Content-Type: multipart/mixed; boundary="dwoA3mc8kTndD7MCJWE40LcI0VRPpFg8N"; protected-headers="v1" From: Mathieu Arnold <mat@FreeBSD.org> To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <e2a17a43-d9f9-dbc7-a73c-5317440b4357@FreeBSD.org> Subject: Re: svn commit: r435576 - head/devel/pkgconf References: <201703070103.v2713JtB059883@repo.freebsd.org> In-Reply-To: <201703070103.v2713JtB059883@repo.freebsd.org> --dwoA3mc8kTndD7MCJWE40LcI0VRPpFg8N Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 07/03/2017 =C3=A0 02:03, Dag-Erling Sm=C3=B8rgrav a =C3=A9crit : > Author: des > Date: Tue Mar 7 01:03:19 2017 > New Revision: 435576 > URL: https://svnweb.freebsd.org/changeset/ports/435576 > > Log: > Change the search path to include ${PREFIX}/lib/pkgconfig ahead of th= e > usual ${PREFIX}/libdata/pkgconfig and /usr/libdata/pkgconfig. This > renders 82.6% of Mk/Uses/pathfix.mk obsolete. I am wondering how you came to commit this without getting approval from = portmgr. We always had a policy about putting the pkg-config files in libdata/pkgc= onfig and not in lib. And you just changed that 20 years old policy without even a discussion a= bout the repercussions it would have. For example, there is a lot of software around that knows that FreeBSD ha= s the .pc files in libdata/pkgconfig, and now, with this, you are paving = the way to moving things in lib, and I figure we are going to need a USES= =3Dpathunfix to put things where you changed it. So, before changing this policy, I am going to ask you, as portmgr, to pl= ease back the change out. Once this is done, and if you feel strongly about it, we can always discu= ss changing the policy, and then test that it will not break things, and = then, maybe change the policy. But only after all those steps. Regards, > Reviewed by: bapt > Approved by: bapt > > Modified: > head/devel/pkgconf/Makefile > > Modified: head/devel/pkgconf/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/devel/pkgconf/Makefile Tue Mar 7 00:06:43 2017 (r435575) > +++ head/devel/pkgconf/Makefile Tue Mar 7 01:03:19 2017 (r435576) > @@ -2,6 +2,7 @@ > =20 > PORTNAME=3D pkgconf > PORTVERSION=3D 1.3.0 > +PORTREVISION=3D 1 > CATEGORIES=3D devel > MASTER_SITES=3D https://distfiles.dereferenced.org/pkgconf/ \ > http://files.etoilebsd.net/pkgconf/ > @@ -16,7 +17,7 @@ GNU_CONFIGURE=3D yes > INSTALL_TARGET=3D install-strip > USE_LDCONFIG=3D yes > TEST_TARGET=3D check > -CONFIGURE_ARGS=3D --with-pkg-config-dir=3D${PREFIX}/libdata/pkgconfig:= /usr/libdata/pkgconfig \ > +CONFIGURE_ARGS=3D --with-pkg-config-dir=3D${PREFIX}/lib/pkgconfig:${PR= EFIX}/libdata/pkgconfig:/usr/libdata/pkgconfig \ > --with-system-libdir=3D/usr/lib \ > --with-system-includedir=3D/usr/include > MAKE_ARGS=3D MANDIR=3D"${MAN1PREFIX}/man/man1" > > --=20 Mathieu Arnold --dwoA3mc8kTndD7MCJWE40LcI0VRPpFg8N-- --Q4V4G7wK7t81vhw9uV55PvMxuGpf0ojE1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJYvx/2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IatoQALiUewkufu1Q9V0UUoQnpj2f GfbyLHHZQp67RrJ9hQaXrEtgBPI0y8K9Z266OMSXwDaGF/UPmYLwKBMjbxEpj03j +6IrDxAd8xINU3AaZk/EwN9xjYJfLcwkXeTGZUydj174fWCYmq0iP3NRW2F//OHe EtOKLfDcVWayD1uaQqcbWCWg9gfqtqhpUFVAY2vrGHHe93QPcqlmEN8VoquI0NR9 BKYVntM0QKMq8VxjZK8LpYzr/C7f1j1ozT2mE/u4xBtGa4NxABWR0SFb2ikSUJe9 nu6U3lmgYnpi++OAvxZOfR+5A6hvNX4GJ4A4fMKlw1AMeMen/hispYFe41z4tEJn Dphj2QLx2Am60y2b/0KsndR8v1aD4X/eRmJnHAn5jRlWYH0OPSdUdphWiCdrJS6D Pjns+ah5J7xflqsXXSUE4MOdS25hPa7V5qJDlAiE+OCiFeQpfKFUtvM9t8rt50i2 Edt4tGzN4VFEt15arUjTqGt/rLOnYyZNI3ZmyGbMtlMD0k5JowCg2UY742ckB1fi BRjaOGCXm8Qwet5qrg96O9Dru7UGg6WgLQ/8Qapnchzn9b3zSZDb4UdAUVCVHdEW +MfwyZJKUa0QmEVvKx5shN9ji2iID2Gx+GMG6CS/LtdANPfHpF+6itHsYYpX7sgB I4J9tSwfmb2xqGY6vk/N =rdwL -----END PGP SIGNATURE----- --Q4V4G7wK7t81vhw9uV55PvMxuGpf0ojE1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e2a17a43-d9f9-dbc7-a73c-5317440b4357>