From owner-freebsd-hackers@FreeBSD.ORG Sat Feb 7 07:38:51 2015 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E9C0797B for ; Sat, 7 Feb 2015 07:38:51 +0000 (UTC) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7772F35F for ; Sat, 7 Feb 2015 07:38:50 +0000 (UTC) Received: by labgd6 with SMTP id gd6so5215902lab.4 for ; Fri, 06 Feb 2015 23:38:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=UFv6RljvXOlanRLttpFN6QNMjCHHIyyGPMOPsVrotxY=; b=gBT4js4Zq8oodL33TUMjak256acVPLomka6P4zH/StBjQWMQ4dWhO4Pcw2RC5apLnl T/TKQrq6twc9DqFdjDaUXLFuHXQkd1OHo+egVd374PIkOa9ci3sxI5rKHJ5S6dNnZcRv 7g3uLkxWxG2Y9FWwBkGBRaXK4NB+zkOBypsJr8+XvPrul2oLA8la0xWZMYv6k/CYlin9 pRT0ZRTNTTrpJ5qtVqgYEOzpBn1lGnGf5jRqAdB2KN+Eaxnb5Dl395tJmY4vTZaxZkN2 Smmup/tMvLZ+eFLQhKXlED3EoGr2LggrxINBw6GwJRjLkzLQEqpeDxbFtBDgM3Jx53oN jEpg== MIME-Version: 1.0 X-Received: by 10.152.27.41 with SMTP id q9mr6042458lag.118.1423294728933; Fri, 06 Feb 2015 23:38:48 -0800 (PST) Received: by 10.114.78.131 with HTTP; Fri, 6 Feb 2015 23:38:48 -0800 (PST) In-Reply-To: References: Date: Sat, 7 Feb 2015 02:38:48 -0500 Message-ID: Subject: Re: Changing the MTU on a lagg device From: Ryan Stone To: "Pokala, Ravi" Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-hackers@freebsd.org" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2015 07:38:52 -0000 I have a similar patch internally. As best that I can tell, the author of the code didn't want to go to the effort of implementing the error cases on the MTU change, and thought that it was better to explicitly error out if somebody tried to change the MTU rather than causing random unexpected behaviour. You can put me (rstone@) as a reviewer in phabricator if you need your patch reviewed.