From owner-freebsd-current@FreeBSD.ORG Fri Dec 20 07:36:54 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EF7F049E; Fri, 20 Dec 2013 07:36:54 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5D7F71663; Fri, 20 Dec 2013 07:36:54 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id rBK7ah2j025516; Fri, 20 Dec 2013 09:36:43 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua rBK7ah2j025516 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id rBK7agkV025515; Fri, 20 Dec 2013 09:36:42 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 20 Dec 2013 09:36:42 +0200 From: Konstantin Belousov To: Roger Pau Monne Subject: Re: [PATCH v7 01/19] xen: add PV/PVH kernel entry point Message-ID: <20131220073642.GP59496@kib.kiev.ua> References: <1387479296-33389-1-git-send-email-roger.pau@citrix.com> <1387479296-33389-2-git-send-email-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/NOItKPPfAGZtKZd" Content-Disposition: inline In-Reply-To: <1387479296-33389-2-git-send-email-roger.pau@citrix.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: xen-devel@lists.xen.org, julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, gibbs@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Dec 2013 07:36:55 -0000 --/NOItKPPfAGZtKZd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thank you for doing the split. On Thu, Dec 19, 2013 at 07:54:38PM +0100, Roger Pau Monne wrote: > Add the PV/PVH entry point and the low level functions for PVH > initialization. > --- > sys/amd64/amd64/locore.S | 53 +++++++++++++++++++++++++++++++ > sys/amd64/amd64/machdep.c | 72 ++++++++++++++++++++++++++++++++++++++++++ > sys/amd64/include/asmacros.h | 26 +++++++++++++++ The changes to the three files above all protected by #ifdef XENHVM. IMO it is more logical to move the code into xen-specific files. The support would be localized and somewhat postpone morphing the sys/amd64 into the maze of #ifdefs, which is the sys/i386 already. --/NOItKPPfAGZtKZd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSs/OJAAoJEJDCuSvBvK1B+2cQAJKoJaZryNNJuOiN67ocHEHy R3PyKtisqo0b2ABgobYhfv1wxRXfr3fhW2Hqzd9GJfEcg/7hV9KSjilBIDnWrbii 720/VuGFh3vQRIWSu6WqylVPxkPkNrEW6pbzcja/FuxYeyheFanxMT5Fu3/uWxGG CadiT8VErkh6Z4HZnOi0goURiXkzpvU4kc/q0MeeUuPWd1KEA+OPxBmcaOz9+lfi FYmRJ0u3BqmPHvbXQpWMeaTAOS5MdhJkp3v5Q2tFlqNHXNYesm3JpwdaiceHAzUG gfpvBKxxVGw1TP3TcBuxN3v8NMlzsFdaO0EfNXL2jR12x21rs67t4LZxWpsF/5yr 6pAp+1DHWsY4FSKTAvRXI5XHlrA1Zb8IP/egIrtEVC0FoCKdgjgzS1mr3EOIYp4t 126R5fvc7TIcC1yZF6YfdlYrmT6RLducDYptnhibQ9DOixYV1iwiBpCGK5FX5etp Bg8i5SBdxDcqPYQvbg7PH+BaWct1K+Y48a/CDAb9/ACtwk8G+OHHmTEHLpx9NEs5 D38iuAi+bdRPjBVYW8n6CFGXgvSsLzLoYPUshPo9BZt2uB0opo5Og4nnoigSxk/L /hL+SLz3gaYmVNSUGu15UkTRLDuep5Sq4vHba09jmoptLoItxAPA3x4Drt9Je7zK CA4TxTE0C2l+BKLpYjuV =bBCJ -----END PGP SIGNATURE----- --/NOItKPPfAGZtKZd--