Date: Mon, 4 Nov 2002 14:56:17 -0800 (PST) From: Archie Cobbs <archie@dellroad.org> To: Vincent Jardin <vjardin@wanadoo.fr> Cc: net@FreeBSD.org Subject: Re: MPD and MRU Message-ID: <200211042256.gA4MuH5k035381@arch20m.dellroad.org> In-Reply-To: <3DA24BE600FF3EA2@mel-rta7.wanadoo.fr> (added by postmaster@wanadoo.fr) "from Vincent Jardin at Nov 4, 2002 10:19:54 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Vincent Jardin writes:
> It looks like it is not possible to configure any MRU values with MPD, due to
> LCP_MRU_MARGIN (=20).
>
> For example, on the PPPoE links, the values between 1473 to 1491 are not
> possible.
>
> ...
> link.c:
> case SET_MRU:
> case SET_MTU:
> val = atoi(*av);
> name = ((intptr_t)arg == SET_MTU) ? "MTU" : "MRU";
> if (!lnk->phys->type)
> Log(LG_ERR, ("[%s] this link has no type set", lnk->name));
> else if (val < LCP_MIN_MRU)
> Log(LG_ERR, ("[%s] the min %s is %d", lnk->name, name, LCP_MIN_MRU));
> else if (val + LCP_MRU_MARGIN > lnk->phys->type->mru)
> Log(LG_ERR, ("[%s] the max %s on type \"%s\" links is %d",
> lnk->name, name, lnk->phys->type->name,
> lnk->phys->type->mru - LCP_MRU_MARGIN)); /* XXXXXXXXXX */
> else if ((intptr_t)arg == SET_MTU)
> lnk->conf.mtu = val;
> else
> lnk->conf.mru = val;
> break;
> ...
>
> I think that the LCP_MRU_MARGIN tests could be removed or LCP_MRU_MARGIN
> could be set to 0.
Yes, you're right.. that's a hold-over kludge from before.
I'll remove it in the next version. In the meantime, you can
just redefine it to zero.
-Archie
__________________________________________________________________________
Archie Cobbs * Packet Design * http://www.packetdesign.com
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200211042256.gA4MuH5k035381>