From owner-cvs-all Wed Aug 15 23:51:45 2001 Delivered-To: cvs-all@freebsd.org Received: from InterJet.elischer.org (c421509-a.pinol1.sfba.home.com [24.7.86.9]) by hub.freebsd.org (Postfix) with ESMTP id 2227237B405; Wed, 15 Aug 2001 23:51:38 -0700 (PDT) (envelope-from julian@elischer.org) Received: from elischer.org (InterJet.elischer.org [192.168.1.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id XAA15779; Wed, 15 Aug 2001 23:56:43 -0700 (PDT) Message-ID: <3B7B6B93.AC742CAE@elischer.org> Date: Wed, 15 Aug 2001 23:43:31 -0700 From: Julian Elischer X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 5.0-CURRENT i386) X-Accept-Language: en, hu MIME-Version: 1.0 To: Dima Dorfman Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/snp snp.c References: <200108160600.f7G60vB75697@freefall.freebsd.org> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Dima Dorfman wrote: > > dd 2001/08/15 23:00:57 PDT > > Modified files: > sys/dev/snp snp.c > Log: > Don't allocate a 512 byte buffer on the stack in snplwrite. It's > probably harmless in this case, since the latter is called on tty > input, which is usually a result of some system call, so we've got > plenty of stack left. It's still nice to fix these things, though, in > case somebody ever decides this driver is a good example of something > (perhaps "what you probably shouldn't do"). > > Revision Changes Path > 1.62 +13 -6 src/sys/dev/snp/snp.c thanks. Even though it is called on tty input, how do you know how much stack was already used up when your interrupt occured? In -current, none, but in 4.x it could already be almost full. We may want to MFC these changes.. People in some situations have definitly reported wierd things under heavy load in 4.x (though very rarely). (I have one machine here that under extreme load seems to be having some kind of memory corruption. it'd be nice to get these fixes back in 4.x) -- +------------------------------------+ ______ _ __ | __--_|\ Julian Elischer | \ U \/ / hard at work in | / \ julian@elischer.org +------>x USA \ a very strange | ( OZ ) \___ ___ | country ! +- X_.---._/ presently in San Francisco \_/ \\ v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message