From owner-freebsd-ports@FreeBSD.ORG Tue May 11 01:37:05 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 14F391065679 for ; Tue, 11 May 2010 01:37:05 +0000 (UTC) (envelope-from sahil@tandon.net) Received: from spartan.hamla.org (spartan.hamla.org [206.251.255.30]) by mx1.freebsd.org (Postfix) with ESMTP id E776C8FC20 for ; Tue, 11 May 2010 01:37:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by spartan.hamla.org (Postfix) with ESMTP id A221617102 for ; Mon, 10 May 2010 21:37:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tandon.net; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:reply-to:message-id :subject:subject:from:from:date:date:received:received; s=aegis; t=1273541823; bh=lEwtqXdHa9MncgYAEp8X5A5Z8a8A7J+FlwX+KkNFeBk=; b= W9cYFNSLa5LTmlp6Xhf34+7JTb+ZcwUnanT0Q1Tphvgj/mqmBjrXWwcLh/ooF23D kDvkch72c6vPadLvRo04OkrTHVUAsaUiMmiA8yki/i/li8JT8taviTc3gQht98sI r1AlfZUoYeAVOBreHWVD/kJ2/BtmYjb8nmzRmYpTQJs= X-Virus-Scanned: by ClamAV at spartan.hamla.org Received: from spartan.hamla.org ([127.0.0.1]) by localhost (spartan.hamla.org [127.0.0.1]) (amavisd-new, port 10027) with LMTP id p5cOJ5Wxb5Rg for ; Mon, 10 May 2010 21:37:03 -0400 (EDT) Received: from magic.hamla.org (cpe-69-201-179-80.nyc.res.rr.com [69.201.179.80]) by spartan.hamla.org (Postfix) with ESMTPSA id 154B317045 for ; Mon, 10 May 2010 21:37:03 -0400 (EDT) Date: Mon, 10 May 2010 21:37:01 -0400 From: Sahil Tandon To: freebsd-ports@freebsd.org Message-ID: <20100511013700.GA34279@magic.hamla.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Subject: Re: ccache 3.0 port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: freebsd-ports@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2010 01:37:05 -0000 On Mon, 10 May 2010, Christer Edwards wrote: > but I'm running into complaints from portlint that I'm not sure how to > address. > > I am eager to learn and I'm happy to dedicate the time to put this > together, if someone doesn't mind offering advice on getting it to > pass portlint's critical eye. % portlint -a WARN: Makefile: only one MASTER_SITE configured. Consider adding additional mirrors. FATAL: Makefile: PORTVERSION looks illegal. You should modify "3.0pre1". The first one can be ignored if there are truly no other mirrors, but we know there are. :) You could enumerate them or use MASTER_SITE_SAMBA; the following is untested and might have unintended consequences, so please review the appropriate Mk files and proceed with caution. You might also think of a more succinct solution. MASTER_SITES= ${MASTER_SITE_SAMBA:S|/samba||} MASTER_SITE_SUBDIR= ${PORTNAME} Regarding portlint's FATAL output, please review Package Naming Conventions in the Handbook. Specifically, "If the software version has strings like ``alpha'', ``beta'', ``rc'', or ``pre'', take the first letter and put it immediately after a period." So you could try sometihng like: PORTVERSION= 3.0.p1 DISTNAME= ${PORTNAME}-${PORTVERSION:S/.p/pre/} -- Sahil Tandon