Date: Thu, 7 Mar 2002 18:26:40 +0600 From: Alexey Dokuchaev <danfe@cytherea.weblab.nsu.ru> To: "David O'Brien" <obrien@freebsd.org> Cc: Mark Murray <markm@freebsd.org>, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/rwall rwall.c Message-ID: <20020307182640.A87748@cytherea.weblab.nsu.ru> In-Reply-To: <20020307041457.A66608@dragon.nuxi.com>; from obrien@freebsd.org on Thu, Mar 07, 2002 at 04:14:57AM -0800 References: <20020307033328.A64158@dragon.nuxi.com> <200203071210.g27CA8RV010023@grimreaper.grondar.org> <20020307041457.A66608@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 07, 2002 at 04:14:57AM -0800, David O'Brien wrote: > On Thu, Mar 07, 2002 at 12:10:08PM +0000, Mark Murray wrote: > > > On Thu, Mar 07, 2002 at 11:27:02AM +0000, Mark Murray wrote: > > > > > - if ((fd = mkstemp(tmpname)) == -1 || !(fp = fdopen(fd, "r+"))) > > > > > + fd = mkstemp(tmpname); > > > > > + fp = fdopen(fd, "r+"); > > > > > + if (fd == -1 || !fp) > > > > > > > > > > Why did you need to do such code restructuring? > > > > > > > > "Assignment statement in conditional". I also happens to be more readable. > > > > > > Feh. Please back this type of changes out. The logic is not the same > > > before and after. > > > > Here is the clearer fix: > > The original code was cleaner. Since we are getting into HO's; we should > stick with the original version. I fully agree. ./danfe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020307182640.A87748>